Closed Bug 1355211 Opened 8 years ago Closed 8 years ago

Scrolling the search tree also scrolls the preferences page

Categories

(Firefox :: Settings UI, defect)

55 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox55 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Follow-up from bug 1348828. (In reply to ItielMaN from comment #17) > I can confirm this is fixed in latest Nightly, but something seems off. > If the search engine list is scrollable, scrolling in it scrolls *also* the > whole settings page. This was not intended. Patch on its way.
Attachment #8856691 - Flags: review?(enndeakin)
Comment on attachment 8856691 [details] Bug 1355211 - Scroll events should be prevented in all cases except when allowunderflowscroll is true and the scrollbar is hidden. https://reviewboard.mozilla.org/r/128628/#review131470 ::: toolkit/content/widgets/tree.xml:722 (Diff revision 1) > this._touchY = -1; > ]]> > </handler> > <handler event="MozMousePixelScroll"> > <![CDATA[ > - if (this.getAttribute("allowunderflowscroll") != "true" && > + if (this.getAttribute("allowunderflowscroll") != "true" || Isn't this the same as: !(this.getAttribute("allowunderflowscroll") == "true" && this.getAttribute("hidevscroll") == "true")
Attachment #8856691 - Flags: review?(enndeakin)
Attachment #8856691 - Flags: review?(enndeakin)
Comment on attachment 8856691 [details] Bug 1355211 - Scroll events should be prevented in all cases except when allowunderflowscroll is true and the scrollbar is hidden. https://reviewboard.mozilla.org/r/128628/#review131490
Attachment #8856691 - Flags: review?(enndeakin) → review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ccf64da3e8c0 Scroll events should be prevented in all cases except when allowunderflowscroll is true and the scrollbar is hidden. r=enndeakin+6102
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Confirmed fixed in latest Nightly, but I think this negates and counteracts (in a way) what was done in bug 1348828. Currently, if the scroller is positioned at the top (or bottom) of the scrollbar, the user can't scroll up (or down) and have to relocate the cursor elsewhere to scroll. I think the search engine list should ignore scroll events if the scroller is: 1. at the top, and the user scrolls up, or 2. at the bottom, and the user scrolls down.
Flags: needinfo?(jaws)
Thanks, what you're asking for would be a nice feature, but it's a bit less priority than this bug and the one that preceded it. Can you please file a new bug for it though?
Status: RESOLVED → VERIFIED
Flags: needinfo?(jaws)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8) > Thanks, what you're asking for would be a nice feature, but it's a bit less > priority than this bug and the one that preceded it. Can you please file a > new bug for it though? Done.

This seems reappears (or it's a different UI element than what we have 4 years ago?): bug 1689865

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: