Closed
Bug 1355764
Opened 8 years ago
Closed 7 years ago
Replace window drag space above tabs with space at the start of the tab strip
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-visual][p2][57])
Attachments
(2 files, 1 obsolete file)
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Flags: qe-verify+
QA Contact: ovidiu.boca
Assignee | ||
Updated•8 years ago
|
Whiteboard: [photon-visual][57] → [photon-visual][p2][57]
Updated•8 years ago
|
QA Contact: ovidiu.boca → brindusa.tot
Assignee | ||
Comment 2•8 years ago
|
||
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Updated•8 years ago
|
Iteration: 55.5 - May 15 → 55.6 - May 29
Updated•7 years ago
|
Iteration: 55.6 - May 29 → 55.7 - Jun 12
Assignee | ||
Updated•7 years ago
|
Attachment #8865970 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
status-firefox55:
affected → ---
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
OS: Windows → All
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8872935 [details]
Bug 1355764 - Replace window drag space above tabs with space at the start of the tab strip.
https://reviewboard.mozilla.org/r/144478/#review148362
Looks mostly good, one small issue:
This variable on OSX is still based on the previous spacing: https://searchfox.org/mozilla-central/source/browser/themes/osx/browser.css#9
That makes the buttonbox on OSX look a bit off. Weirdly, it's only used once in the tree: https://searchfox.org/mozilla-central/search?q=windowButtonMarginTop&path=
So I'd suggest removing it and setting the margin-top to 6px, same as compact theme: https://searchfox.org/mozilla-central/source/browser/themes/osx/compacttheme.css#32
Attachment #8872935 -
Flags: review?(jhofmann)
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8872935 [details]
Bug 1355764 - Replace window drag space above tabs with space at the start of the tab strip.
https://reviewboard.mozilla.org/r/144478/#review148374
Thanks!
Attachment #8872935 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a894530a99b
Replace window drag space above tabs with space at the start of the tab strip. r=johannh
Comment 8•7 years ago
|
||
Backed out for causing Win7 browser_roundedWindow_newWindow.js failures.
https://hg.mozilla.org/integration/autoland/rev/7fb3d9dfa8e684d5258a3d96b7176a1fa95fe205
https://treeherder.mozilla.org/logviewer.html#?job_id=103502703&repo=autoland
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)
> Backed out for causing Win7 browser_roundedWindow_newWindow.js failures.
> https://hg.mozilla.org/integration/autoland/rev/
> 7fb3d9dfa8e684d5258a3d96b7176a1fa95fe205
>
> https://treeherder.mozilla.org/logviewer.html#?job_id=103502703&repo=autoland
This appears to be a bug in calcMaximumAvailSize: http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/browser/components/resistfingerprinting/test/browser/head.js#10
It calculates the chrome dimensions in a maximized window, and then tests use them to measure non-maximized windows.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/215cfdee973f
Replace window drag space above tabs with space at the start of the tab strip. r=johannh
Comment 14•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 15•7 years ago
|
||
Screenshots:
https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=edffa38ec0c515198f360f23d286290cb5081996&newProject=mozilla-central&newRev=cac2fd43de81d44b36396704220996b0c4a39f1a
Unfortunately a bit incomplete and full of other changes, but you can see the drag space on Windows 7 and lack of drag space on Linux (which is intended I think).
Comment 16•7 years ago
|
||
Any option to disable this? Maximized window looks goofy now :-/
Assignee | ||
Comment 17•7 years ago
|
||
(In reply to Geobert Quach from comment #16)
> Any option to disable this? Maximized window looks goofy now :-/
That's bug 1369786.
Comment 18•7 years ago
|
||
Verified as fixed on latest Nightly 55.0a1 build ID 20170609030207, on Windows 10 x64 and Mac 10.12.
For Ubuntu, as I see in the mockups (https://people-mozilla.org/~shorlander/projects/photon/Mockups/linux.html) there is no space for dragging the window. I verified on Ubuntu 16.04 and I could not observe any space at the start of the tabs strip for window dragging(please see attachment).Is this intentional for Ubuntu OS-es?
Flags: needinfo?(dao+bmo)
Comment 20•7 years ago
|
||
Based on comments 18 and 19, mark bug verified-fixed.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•