Closed Bug 135666 Opened 23 years ago Closed 23 years ago

Creating bugs: OS detection doesn't work for Internet Explorer, Win NT 4.0

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

2.15
x86
Windows NT
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: johannes.pellenz, Assigned: timeless)

Details

Attachments

(1 file, 1 obsolete file)

If a new bug is entered from a PC running Windows NT 4.0 and Internet Explorer, the operating system cannot be detected (you get 'other'). The problem is that the browser identifies itself as Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 4.0) which does not match in sub pickos in enter_bug.cgi. One solution ist to change the line /Mozilla.*\(Windows.*NT/ && do {return "Windows NT";}; to /Mozilla.*Windows.*NT/ && do {return "Windows NT";}; so that no '(' is required the string 'Windows'.
Timeless, this is probably yours :-)
This was fixed in CVS back in November... *** This bug has been marked as a duplicate of 107672 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
I checked again with the 2.15 version from the CVS server, and the bug is still there. This time I will add a patch that fixes the problem.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Version: 2.14.1 → 2.15
Attached patch Patch so that Win NT OS is detected (obsolete) (deleted) — Splinter Review
ok, if we're going to tweak that line, then i'd like to tweak the line above it too. I'll look at this on sunday.
Assignee: myk → timeless
Status: REOPENED → NEW
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.16
Attached patch Patch v.2 (deleted) — Splinter Review
Fixed the line above as timeless requested. Also "standardized" the original line that was changed so that it matched the other lines. See this web page for a sampling of MSIE user agents: http://browserwatch.internet.com/stats/ua-microsoft.html And for the record, Netscape/Mozilla user agents: http://browserwatch.internet.com/stats/ua-netscape.html
Attachment #78929 - Attachment is obsolete: true
See also Bug 92763.
Keywords: patch, review
Comment on attachment 78942 [details] [diff] [review] Patch v.2 I can't test this (not having win2k available), but it looks reasonable. r=bbaetz - does this work with mozilla on thpose platforms, too?
Attachment #78942 - Flags: review+
I tested Patch v.2 (attachment 78942 [details] [diff] [review]) using the following OS' and browsers: Win NT 4.0, IE 5.0, Win NT 4.0, Mozilla 0.9.9, Win2k, IE 5.0 and Win2k, Mozilla 0.9.9. The OS detection worked correctly in all cases.
This will be fixed by the patch on bug 92763, which happens to include the same changes as the patch here, and has already been approved for checkin. *** This bug has been marked as a duplicate of 92763 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → DUPLICATE
Target Milestone: Bugzilla 2.16 → ---
The patches are not identical. The other bug mathces on Windows XP and Windows NT 5.1, to XP, whilst this patch changes the NT4 and 2K regexp so that the os is not the first item in the brackets. (Although the 2K one probably already matches) Reopening.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment on attachment 78942 [details] [diff] [review] Patch v.2 my mistake... I wasn't reading that close enough. Since these are two separate things, this one looks good, too.
Attachment #78942 - Flags: review+
Target Milestone: --- → Bugzilla 2.16
checked in
Status: REOPENED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: