Closed
Bug 135666
Opened 23 years ago
Closed 23 years ago
Creating bugs: OS detection doesn't work for Internet Explorer, Win NT 4.0
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: johannes.pellenz, Assigned: timeless)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bbaetz
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
If a new bug is entered from a PC running Windows NT 4.0 and Internet Explorer,
the operating system cannot be detected (you get 'other').
The problem is that the browser identifies itself as
Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 4.0)
which does not match in sub pickos in enter_bug.cgi.
One solution ist to change the line
/Mozilla.*\(Windows.*NT/ && do {return "Windows NT";};
to
/Mozilla.*Windows.*NT/ && do {return "Windows NT";};
so that no '(' is required the string 'Windows'.
Comment 1•23 years ago
|
||
Timeless, this is probably yours :-)
Comment 2•23 years ago
|
||
This was fixed in CVS back in November...
*** This bug has been marked as a duplicate of 107672 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 3•23 years ago
|
||
I checked again with the 2.15 version from the CVS server, and the bug is still
there. This time I will add a patch that fixes the problem.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Version: 2.14.1 → 2.15
Reporter | ||
Comment 4•23 years ago
|
||
ok, if we're going to tweak that line, then i'd like to tweak the line above it too. I'll look at this on sunday.
Assignee: myk → timeless
Status: REOPENED → NEW
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.16
Comment 6•23 years ago
|
||
Fixed the line above as timeless requested. Also "standardized"
the original line that was changed so that it matched the other
lines.
See this web page for a sampling of MSIE user agents:
http://browserwatch.internet.com/stats/ua-microsoft.html
And for the record, Netscape/Mozilla user agents:
http://browserwatch.internet.com/stats/ua-netscape.html
Attachment #78929 -
Attachment is obsolete: true
Comment 8•23 years ago
|
||
Comment on attachment 78942 [details] [diff] [review]
Patch v.2
I can't test this (not having win2k available), but it looks reasonable.
r=bbaetz - does this work with mozilla on thpose platforms, too?
Attachment #78942 -
Flags: review+
Reporter | ||
Comment 9•23 years ago
|
||
I tested Patch v.2 (attachment 78942 [details] [diff] [review]) using the following OS' and browsers:
Win NT 4.0, IE 5.0,
Win NT 4.0, Mozilla 0.9.9,
Win2k, IE 5.0 and
Win2k, Mozilla 0.9.9.
The OS detection worked correctly in all cases.
Comment 10•23 years ago
|
||
This will be fixed by the patch on bug 92763, which happens to include the same
changes as the patch here, and has already been approved for checkin.
*** This bug has been marked as a duplicate of 92763 ***
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → DUPLICATE
Updated•23 years ago
|
Target Milestone: Bugzilla 2.16 → ---
Comment 11•23 years ago
|
||
The patches are not identical. The other bug mathces on Windows XP and Windows
NT 5.1, to XP, whilst this patch changes the NT4 and 2K regexp so that the os is
not the first item in the brackets. (Although the 2K one probably already matches)
Reopening.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 12•23 years ago
|
||
Comment on attachment 78942 [details] [diff] [review]
Patch v.2
my mistake... I wasn't reading that close enough. Since these are two
separate things, this one looks good, too.
Attachment #78942 -
Flags: review+
Updated•23 years ago
|
Target Milestone: --- → Bugzilla 2.16
Assignee | ||
Comment 13•23 years ago
|
||
checked in
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•