QNX and BeOS among others are ignored. I've been doing piecewise mods for a while, here's a revamp.

Comment on attachment 55844 [details] [diff] [review] rewrite discrimination alg r=bbaetz There are no new platforms added, so this shouldn't make it more likely to run into bug 106993

-> Patch Writer

Comment on attachment 55844 [details] [diff] [review] rewrite discrimination alg why are the XP ones commented out? (I know we hate them, but they're out there...)

they're commmented out because bugzilla.mozilla.org didn't have "Windows XP" in its os list. myk says that's fixed shortly so i'd gladly fix my patch, however http://lxr.mozilla.org/mozilla/search?string=Windows%20XP has only 2 hits, and neither are in or near webtools. I'd like to check this in now as is, or w/o the 2 #'d lines, so i make the same cut as the rest of the patches that are landing for weds or whatever.

Comment on attachment 55844 [details] [diff] [review] rewrite discrimination alg I didn't try this on every platform, but in my brief testing it seems to work fine. It also passed all the tests (didn't cause any orange or red :) and looked correct. I agree that we should add Windows XP (uncomment those two lines), but I don't think we should do it until we fix at least bug 92763. It wouldn't be a bad idea to also fix bug 106993 as adding "Windows XP" to the localconfig default (to fix bug 92763) wouldn't add it to existing installations. Will comment on bug 92763 in a minute. r=jake (and undoing Dave's needs-work as there are other issues holding up adding XP to the default distribution... Myk/Dawn should probably uncomment these lines at b.m.o after the update so they can automagically detect XP... will also add a comment to bug 103885).

checked in. someone can provide an XP patch as part of bug 92763.

fixing incorrect milestones on fixed bugs.

*** Bug 135666 has been marked as a duplicate of this bug. ***