Closed
Bug 1357715
(stylo-devtools-tests)
Opened 8 years ago
Closed 7 years ago
[meta] Stylo: Pass DevTools tests
Categories
(Core :: CSS Parsing and Computation, enhancement, P5)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
(Blocks 1 open bug)
Details
(Keywords: meta)
Attachments
(1 file)
We should start to look at DevTools test failures with Stylo enabled since DevTools uses additional code paths that might not be hit when just styling content normally.
An example try run[1] shows the current state.
[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=752bed7671c8df3c830b37df3115f5aa647c6428
Assignee | ||
Updated•8 years ago
|
Priority: -- → P5
Assignee | ||
Comment 1•8 years ago
|
||
Updated run now that a few crashing issues were fixed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c5f4a1469f213ae25760cebfd5ea5f425b576ec
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Some historical DevTools failure counts (looking at e10s opt only):
2017-04-19: 376
2017-05-23: 183
2017-06-07: 172
2017-06-16: 159
So, making progress at least! Some runs do crash though, so potentially more failures will be revealed once crashes are fixed.
Assignee | ||
Comment 6•7 years ago
|
||
Marking leave-open to use this bug to land some DevTools expectation updates for platform features that don't block shipping Stylo.
Keywords: leave-open
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8880071 [details]
Bug 1357715 - Skip DevTools tests on Stylo that use shadow DOM.
https://reviewboard.mozilla.org/r/151392/#review156538
Attachment #8880071 -
Flags: review?(cam) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a7a5b2fc4f0a
Skip DevTools tests on Stylo that use shadow DOM. r=heycam
Comment 10•7 years ago
|
||
bugherder |
Comment 11•7 years ago
|
||
this caused perma failures after this landed on m-c like https://treeherder.mozilla.org/logviewer.html#?job_id=109517923&repo=mozilla-central
Flags: needinfo?(jryans)
Comment 12•7 years ago
|
||
Backout by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/594cc32b6323
Backed out changeset a7a5b2fc4f0a for causing perma failures after merged to m-c
Assignee | ||
Comment 13•7 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #11)
> this caused perma failures after this landed on m-c like
> https://treeherder.mozilla.org/logviewer.html#?job_id=109517923&repo=mozilla-
> central
Bug 1375699 made the pref optional again, so we need to keep the try blocks.
Flags: needinfo?(jryans)
Comment hidden (mozreview-request) |
Comment 15•7 years ago
|
||
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e6dfe16f777b
Skip DevTools tests on Stylo that use shadow DOM. r=heycam
Comment 16•7 years ago
|
||
bugherder |
Assignee | ||
Comment 17•7 years ago
|
||
Assignee | ||
Comment 18•7 years ago
|
||
New failure count entry:
2017-04-19: 376
2017-05-23: 183
2017-06-07: 172
2017-06-16: 159
2017-06-29: 140
Assignee | ||
Comment 19•7 years ago
|
||
Assignee | ||
Comment 20•7 years ago
|
||
Assignee | ||
Comment 21•7 years ago
|
||
New failure count entry:
2017-04-19: 376
2017-05-23: 183
2017-06-07: 172
2017-06-16: 159
2017-06-29: 140
2017-07-11: 146
Assignee | ||
Comment 22•7 years ago
|
||
Assignee | ||
Comment 23•7 years ago
|
||
New failure count entry:
2017-04-19: 376
2017-05-23: 183
2017-06-07: 172
2017-06-16: 159
2017-06-29: 140
2017-07-11: 146
2017-07-12: 180
Assignee | ||
Comment 24•7 years ago
|
||
Assignee | ||
Comment 25•7 years ago
|
||
Assignee | ||
Comment 26•7 years ago
|
||
Assignee | ||
Comment 27•7 years ago
|
||
New failure count entry:
2017-04-19: 376
2017-05-23: 183
2017-06-07: 172
2017-06-16: 159
2017-06-29: 140
2017-07-11: 146
2017-07-12: 180
2017-07-24: 171
Updated•7 years ago
|
Blocks: stylo-mochitest
Assignee | ||
Comment 28•7 years ago
|
||
Assignee | ||
Comment 29•7 years ago
|
||
New failure count entry:
2017-04-19: 376
2017-05-23: 183
2017-06-07: 172
2017-06-16: 159
2017-06-29: 140
2017-07-11: 146
2017-07-12: 180
2017-07-24: 171
2017-07-25: 53
Assignee | ||
Comment 30•7 years ago
|
||
New failure count entry:
2017-04-19: 376
2017-05-23: 183
2017-06-07: 172
2017-06-16: 159
2017-06-29: 140
2017-07-11: 146
2017-07-12: 180
2017-07-24: 171
2017-07-25: 53
2017-08-01: 46
Assignee | ||
Comment 31•7 years ago
|
||
All DevTools tests are active with Stylo!
Assignee: nobody → jryans
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•