Stylo's CSS error reporting is missing the followup messages that Gecko provides, such as for "display: invalid".

Fixing this makes it slightly simpler to manage a few DevTools tests happen to check exact strings of CSS errors. We could also instead change those tests if we don't get around to this in time.

The Servo-side changes are in https://github.com/servo/servo/pull/17859.

Comment on attachment 8890105 [details] [diff] [review] Append skipped/dropped message to Stylo CSS error reports Review of attachment 8890105 [details] [diff] [review]: ----------------------------------------------------------------- (In future, if you could attach patches with 8 lines of context, that should make it easier for me to review. Even better if you use mozreview, since I can expand the context myself!) ::: layout/style/ServoBindings.cpp @@ +2678,5 @@ > nsAutoString wideParam = NS_ConvertUTF8toUTF16(paramValue); > reporter->ReportUnexpectedUnescaped(message, wideParam); > + if (followup) { > + reporter->ReportUnexpected(followup); > + } This is OK, although there are some cases where Gecko will report three errors before calling OutputError, such as here: http://searchfox.org/mozilla-central/rev/8a61c71153a79cda2e1ae7d477564347c607cc5f/layout/style/nsCSSParser.cpp#1978-1986 (Whether any > 2 message cases will come up in the error messages you are trying to match on I'm not sure. Maybe maximum 2 is good enough.)

Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5a8e20149490 Append skipped/dropped message to Stylo CSS error reports. r=heycam