Closed Bug 135975 Opened 23 years ago Closed 23 years ago

Theme preview images are outdated

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: gregvalure, Assigned: shliang)

References

Details

(Keywords: polish, Whiteboard: [adt3])

Attachments

(3 files, 5 obsolete files)

The theme preview images are outdated, especially Classic. In both themes: - The menu has changed. No Search or Tasks menus anymore, added Tools, Window, etc. - Minor positioning and size changes for almost everything. In Modern: - Fonts have changed. In Classic (Windows/Unix): - The main icons have been changed slightly. (by bug 125526 and bug 123666) - Bookmarks and Home buttons changed position. - Urlbar font is smaller. - Grippies are thinner. - Doesn't use default Windows colors. - Shows Netscape-specific links and home page. (would take care of bug 83912) I don't have access to a Mac, so someone else needs to make a new Mac Classic image. Also, this bug is broader than bug 83912, so don't dup it. 2002-04-04-03 Win98
Attached image Updated themes/classic/global/win/preview.gif (obsolete) (deleted) —
Attached image Updated themes/modern/global/preview.gif (obsolete) (deleted) —
Marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Nominating for M1.
Keywords: mozilla1.0, polish
Since we're replacing the previews anyway, I've decided to make a few improvements. First, the preview starts at the Navigation toolbar instead of the menu. This removes the extra dependency so it won't go out of date as often, but more importantly it makes the preview accurate on both PC and Mac. Classic has a Mac-specific preview but Modern does not. Also, all the buttons are enabled for a better sense of the style, and a Mozilla.org bookmark is added to the personal toolbar to fill some of the empty space. I don't have the privileges to mark the first two obsolete.
I like the new images. I'll obsolete the first two attachments for you.
Attachment #78054 - Attachment is obsolete: true
Attached image Mac Classic Skin (obsolete) (deleted) —
Sorry, couldn't get the Stop button active.
Attachment #78055 - Attachment is obsolete: true
Attached image Better themes/classic/global/mac/preview.gif (obsolete) (deleted) —
Ah, but that's what image editors are for. Enabled the Stop button. Also dropped the mozilla.org site icon because we should be showing off the generic styles. That, and the fact that the site icons aren't technically supposed to be in the personal toolbar anymore, even though after two patches they still are. Can't keep a good feature down. Anyway, it needed to be a .gif too. Now if we can obsolete the first Mac image, I can start on getting these approved.
Comment on attachment 78469 [details] Mac Classic Skin Obsoleted as requested. BTW: why not use PNGs ? There's ancient wisdom that they're not allowed in skins, but that goes back well over a year now (when we had a different graphics library) *and* these few images for the prefs are nothing like converting a whole skin to PNG. Someone should really try that again post 1.0.
Attachment #78469 - Attachment is obsolete: true
I was thinking the same thing today. I'm thinking of claiming bug 8415 (and probably splitting it into smaller ones) and working on just that. For now it's just one less file to change.
*** Bug 83912 has been marked as a duplicate of this bug. ***
Comment on attachment 78727 [details] Better themes/classic/global/mac/preview.gif Not sure if this reflects the skin as most folks (OS9) will see it (no lines in the background)
Comment on attachment 78258 [details] Better themes/classic/global/win/preview.gif looks ok r=andreww
Attachment #78258 - Flags: review+
Comment on attachment 78259 [details] Better themes/modern/global/preview.gif looks ok r=andreww
Attachment #78259 - Flags: review+
Attachment #78727 - Flags: needs-work+
> Not sure if this reflects the skin as most folks (OS9) will see it (no lines in > the background) Can't Mac OS 9 and Mac OS X have separate Classic preview images? I'm sure someone with OS 9 could take a nice screenshot.
Attached image OS9 themes/classic/global/mac/preview.gif (obsolete) (deleted) —
Mac OS 9 version of the image. I'm attaching the OS X version to bug 134670, which deals with giving OS X its own preview. Use that bug to work on getting different previews in different Mac builds.
Attachment #78727 - Attachment is obsolete: true
Oops. The URL wasn't right.
Attachment #79109 - Attachment is obsolete: true
Comment on attachment 79110 [details] OS9 themes/classic/global/mac/preview.gif r=andreww
Attachment #79110 - Flags: review+
One comment - I know this is not a mozilla issue but could the creator of these two previews please take a look at ns6(.22) and create theme previews for them as well? You can send them to me directly (andreww@netscape.com). What I mean is the skin previews are different for "commercial" builds, and I want to make sure they are in sync. -Thanks
sr=hewitt for all
Images need to be updated to match the product(s). This can go in for RTM.
Keywords: nsbeta1+
Whiteboard: [adt3]
asked for drivers approval
Attachment #78258 - Flags: superreview+
Attachment #78259 - Flags: superreview+
Attachment #79110 - Flags: superreview+
Comment on attachment 79110 [details] OS9 themes/classic/global/mac/preview.gif a=rjesup@wgate.com for branch checkin after RC1. Please remember to check into trunk if not already done.
Attachment #79110 - Flags: approval+
fixed in trunk and branch
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified both branch build (2002-05-02-12-1.0.0) and trunk build (2002-05-03-03- TRUNK)
Status: RESOLVED → VERIFIED
Keywords: verified1.0.0
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: