Closed Bug 1361969 Opened 8 years ago Closed 8 years ago

Update the URL of "Firefox Support" Link at the bottom-left side on the Preferences page

Categories

(Firefox :: Settings UI, enhancement, P1)

Product:
Firefox
Component:
Settings UI
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Bug 1361969 - Update the URL of "Firefox Support" Link
(deleted), text/x-review-board-request
mconley
: review+
Details
Whiteboard: [photon-preference]
Flags: qe-verify+
QA Contact: hani.yacoub
Received an email from Joni Savage. We want to change the URL to `https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/preferences`.
Mike's review queue maxed out, and Jared is on PTO. We might need to wait for some time and continue to review the patch.
Comment on attachment 8864554 [details] Bug 1361969 - Update the URL of "Firefox Support" Link https://reviewboard.mozilla.org/r/136222/#review139222 ::: browser/components/preferences/in-content/preferences.js:147 (Diff revision 1) > > function onHashChange() { > gotoPref(); > } > > function gotoPref(aCategory) { Given that the link no longer change w/ helpTopic, do you want to move it to somewhere else so we don't set it again whenever user switch pane?
Attachment #8864554 - Flags: review?(mconley)
Comment on attachment 8864554 [details] Bug 1361969 - Update the URL of "Firefox Support" Link https://reviewboard.mozilla.org/r/136222/#review139222 > Given that the link no longer change w/ helpTopic, do you want to move it to somewhere else so we don't set it again whenever user switch pane? Good point. Let's do it.
Comment on attachment 8864554 [details] Bug 1361969 - Update the URL of "Firefox Support" Link https://reviewboard.mozilla.org/r/136222/#review140128 ::: browser/components/preferences/in-content/preferences.js (Diff revision 2) > category = kDefaultCategoryInternalName; > item = categories.querySelector(".category[value=" + category + "]"); > } > > - let helpButton = document.querySelector(".help-button"); > - helpButton.setAttribute("href", getHelpLinkURL(item.getAttribute("helpTopic"))); Sorry for not spotting that earlier; do you want to remove this property also? http://searchfox.org/mozilla-central/rev/8b70b0a5038ef9472fe7c53e04a70c978bb06aed/toolkit/content/widgets/preferences.xml#1193
Comment on attachment 8864554 [details] Bug 1361969 - Update the URL of "Firefox Support" Link https://reviewboard.mozilla.org/r/136222/#review140128 > Sorry for not spotting that earlier; do you want to remove this property also? > > http://searchfox.org/mozilla-central/rev/8b70b0a5038ef9472fe7c53e04a70c978bb06aed/toolkit/content/widgets/preferences.xml#1193 I think SeaMonkey still uses helpTopic. If there's no pressing reason to remove it, we should leave it.
Comment on attachment 8864554 [details] Bug 1361969 - Update the URL of "Firefox Support" Link https://reviewboard.mozilla.org/r/136222/#review140368 Thanks!
Attachment #8864554 - Flags: review?(mconley) → review+
Thanks Mike for reviewing. Let's land the patch after the treeherder task[1] is good. [1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf893ec5e5d2&selectedJob=97341610
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/09259740487b Update the URL of "Firefox Support" Link r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/09259740487b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Build ID: 20170524030204 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: