Closed Bug 1362210 Opened 8 years ago Closed 4 years ago

Update SeaMonkey branding icons

Categories

(SeaMonkey :: Themes, enhancement)

Product:
SeaMonkey
Component:
Themes
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.86
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: KenSaunders, Assigned: frg)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.8)

Attachments

(4 files, 3 obsolete files)

SeaMonkey-icns.png
(deleted), image/png
Details
SeaMonkey-Mac-Icons.zip
(deleted), application/zip
Details
1362210-brandingicons-v1_2-2538.patch
(deleted), patch
Details | Diff | Splinter Review
1362210-brandingicons-v1_3-2538.patch
(deleted), patch
iannbugzilla
: review+
buc
: feedback+
iannbugzilla
: approval-comm-release+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review
Attached image SeaMonkey-icns.png (deleted) —
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20170413192749 Expected results: Per http://forums.mozillazine.org/viewtopic.php?p=14746198#p14746198 "It would be nice if SeaMonkey's icon in the Mac application package could be brought up to date. It is still 128x128" barbaz "feel free to contribute a 1024x1024 SeaMonkey icon for the Mac application package" I don't have access to a Mac so I can't check the quality, etc. If I can be of further assistance, please let me know. Zip contents see SeaMonkey-icns.png
Attached file SeaMonkey-Mac-Icons.zip (deleted) —
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: SeaMonkey 2.0 Branch → Trunk
IanN, I need to do installer changes because of bustage and also would like to ship hi-res icons with 2.57. What is needed so that we can use these icons here. Is an mpl V2 copyright statement in the zip all which is needed? They need to be converted to png for all platform use but are really nice.
Flags: needinfo?(iann_bugzilla)
(In reply to Frank-Rainer Grahl (:frg) from comment #2) > IanN, I need to do installer changes because of bustage and also would like > to ship hi-res icons with 2.57. What is needed so that we can use these > icons here. Is an mpl V2 copyright statement in the zip all which is needed? > They need to be converted to png for all platform use but are really nice. Maybe Robert knows this, otherwise might need to check with someone else.
Component: General → Themes
Flags: needinfo?(kairo)
Depends on: 1451847
(In reply to Frank-Rainer Grahl (:frg) from comment #2) > They need to be converted to png for all platform use but are really nice. For mac it should be the .icns format (which basically is a package of icons in different resolutions), see https://dxr.mozilla.org/comm-central/source/suite/branding/nightly/icons/mac
Ah, now when I looked in the .zip I see that it contains various .icns files.
Hi, do you know what sort of copyright/licence statement is needed and where?
Flags: needinfo?(mhoye)
MPL agreement should be fine - esp. if the artwork itself is icon material we already have and/or our Mozilla-trademarked logo. That said, we have high-quality SVG files esp. for the logo itself from which any resolution should be able to be derived from.
Flags: needinfo?(kairo)
Flags: needinfo?(mhoye)
Type: defect → enhancement
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → affected
tracking-seamonkey2.53: --- → ?
tracking-seamonkey2.57esr: --- → ?
Blocks: 1674589
Summary: SeaMonkey icns Icons for Mac → Update SeaMonkey branding icons
Attached patch 1362210-brandingicons-2538.patch (obsolete) (deleted) — — Splinter Review

This add new higher resolution icons and svgs. The svgs and pngs were done by buc. I hope I got the latest version in. I moved our the original svg icons into a template folder and the new icons then into the former svg folder. There are currently not use but can be integrated in a follow-up.

Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #9213496 - Flags: feedback?(iann_bugzilla)
Attachment #9213496 - Flags: feedback?(dmitry)

Comment on attachment 9213496 [details] [diff] [review]
1362210-brandingicons-2538.patch

Forgot to add the main logo in svg form. The final v3 one is here https://bugzilla.mozilla.org/show_bug.cgi?id=1674589#c14 .

It could be "seamonkey.svg", "default.svg", "main-window.svg", or all the three together :)

Remove icons/template/svg/semonkey.svg. Unlike the old true "svg/*" stuff, it was just our temporary attempt.

Some optional notes:

It looks that icons/gtk/mainWindow*.png are a bit out of order with another ones there. Could be just main-window.png (32x32), main-window16.png and main-window48.png . The other sizes are present as "default*.png" anyway.

The "default512.png" and "default1024.png" could be dropped. These sizes required for .icns format, but looks extra in a standalone form. (Any system where such sizes could be needed are moderm enough to support svg instead).

Attachment #9213496 - Flags: feedback?(dmitry) → feedback-
Comment on attachment 9213496 [details] [diff] [review] 1362210-brandingicons-2538.patch >+++ b/suite/branding/branding-common.mozbuild if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows': >+ icon_suffix = '.ico' >+ icon_dir = CONFIG['MOZ_WIDGET_TOOLKIT'] Doesn't this just overcomplicate things, surely icon_dir = 'windows' is clearer? Firefox / TB don't seem to have the equivalent of mainwindow* images just default*, do we need them still?
Flags: needinfo?(iann_bugzilla)
Attachment #9213496 - Flags: feedback?(iann_bugzilla) → feedback-

New version with basically default*.png main-window*.png and icon*.png duplicated.

Attachment #9213496 - Attachment is obsolete: true
Attached patch 1362210-brandingicons-2538.patch (obsolete) (deleted) — — Splinter Review

I think this is reviewable. Removed the main-window* icons and didn't spot a difference under Linux. Default*.png seems to be used as a fallback. seamonkey-v3.svg is in and removed under templates.

Next stage would be to add the svg(s) into the package.

FRG

Attachment #9214996 - Flags: feedback?(iann_bugzilla)
Attachment #9214996 - Flags: feedback?(dmitry)
Attached patch 1362210-brandingicons-v1_3-2538.patch (obsolete) (deleted) — — Splinter Review

It helps if you pick the right patch...

Attachment #9214996 - Attachment is obsolete: true
Attachment #9214996 - Flags: feedback?(iann_bugzilla)
Attachment #9214996 - Flags: feedback?(dmitry)
Attachment #9214997 - Flags: feedback?(iann_bugzilla)
Attachment #9214997 - Flags: feedback?(dmitry)

Yes the package-manifest.in was bad. Bill would have found out for the Linux build. doh

Attachment #9214997 - Attachment is obsolete: true
Attachment #9214997 - Flags: feedback?(iann_bugzilla)
Attachment #9214997 - Flags: feedback?(dmitry)
Attachment #9214998 - Flags: feedback?(iann_bugzilla)
Attachment #9214998 - Flags: feedback?(dmitry)

Comment on attachment 9214998 [details] [diff] [review]
1362210-brandingicons-v1_3-2538.patch

LGTM

Attachment #9214998 - Flags: feedback?(dmitry) → feedback+

Comment on attachment 9214998 [details] [diff] [review]
1362210-brandingicons-v1_3-2538.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: blurry branding icons
Testing completed (on m-c, etc.): 2.53.8b1 pre
Risk to taking this patch (and alternatives if risky): not much of a bug.
String changes made by this patch: --

Attachment #9214998 - Flags: review?(iann_bugzilla)
Attachment #9214998 - Flags: feedback?(iann_bugzilla)
Attachment #9214998 - Flags: approval-comm-release?
Attachment #9214998 - Flags: approval-comm-esr60?
Comment on attachment 9214998 [details] [diff] [review] 1362210-brandingicons-v1_3-2538.patch >+++ b/suite/branding/branding-common.mozbuild >+ FINAL_TARGET_FILES.chrome.icons.default += [ >+ 'default128.png', >+ 'default16.png', >+ 'default22.png', >+ 'default24.png', >+ 'default256.png', >+ 'default32.png', >+ 'default48.png', >+ 'default64.png', I'd prefer this sorted by number so 16, 22, 24, 32, 48, 64, 128, 256 >+++ b/suite/installer/package-manifest.in >@@ -587,21 +587,24 @@ > ; shell icons > #ifdef MOZ_GTK > @RESPATH@/chrome/icons/default/bookmarkproperties.png > @RESPATH@/chrome/icons/default/bookmarkproperties16.png > @RESPATH@/chrome/icons/default/bookmarkproperties48.png > @RESPATH@/chrome/icons/default/chatzilla-window.png > @RESPATH@/chrome/icons/default/chatzilla-window16.png > @RESPATH@/chrome/icons/default/chatzilla-window48.png >-@RESPATH@/chrome/icons/default/default.png >+@RESPATH@/chrome/icons/default/default128.png > @RESPATH@/chrome/icons/default/default16.png >+@RESPATH@/chrome/icons/default/default22.png >+@RESPATH@/chrome/icons/default/default24.png >+@RESPATH@/chrome/icons/default/default256.png >+@RESPATH@/chrome/icons/default/default32.png > @RESPATH@/chrome/icons/default/default48.png > @RESPATH@/chrome/icons/default/default64.png >-@RESPATH@/chrome/icons/default/default128.png I'd prefer this sorted by number so 16, 22, 24, 32, 48, 64, 128, 256 r/a=me with those addressed.
Attachment #9214998 - Flags: review?(iann_bugzilla)
Attachment #9214998 - Flags: review+
Attachment #9214998 - Flags: approval-comm-release?
Attachment #9214998 - Flags: approval-comm-release+
Attachment #9214998 - Flags: approval-comm-esr60?
Attachment #9214998 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c81bf129cf44
Update SeaMonkey branding and OS integration icons. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Landed with the wrong reviewer doh.

The order in the suite/branding/branding-common.mozbuild couldn't be changed. The build system expects a sorted list here and unfortunately that means 128 and 256 are in the middle of it. I didn't think splitting it was worth it as discussed on irc. package-manifest.in changed for checkin.

Whiteboard: SM2.53.8
Target Milestone: --- → seamonkey 2.86

For being totally blind, I really enjoy reading all these patches, just out of curiosity, I wonder, as to what they mean, I don't want to make anyone mad, for wanting to learn new things.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: