Closed Bug 1363173 Opened 8 years ago Closed 7 years ago

Update openvr to build with MinGW

Categories

(Core :: WebVR, enhancement)

Product:
Core
Component:
WebVR
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

Bug 1363173 Update OpenVR to build with MinGW
(deleted), text/x-review-board-request
kip
: review+
Details
openvr causes several errors with MinGW. this patch fixes all of them I have found so far. These have been submitted upstream: https://github.com/ValveSoftware/openvr/pull/508 https://github.com/ValveSoftware/openvr/pull/509 https://github.com/ValveSoftware/openvr/pull/510 https://github.com/ValveSoftware/openvr/pull/511
Hey Kip - is this something we'd consider taking for now, since OpenVR indicated they would upstream them so they shouldn't get lost or have to be maintained?
Flags: needinfo?(kgilbert)
(In reply to Tom Ritter [:tjr] from comment #2) > Hey Kip - is this something we'd consider taking for now, since OpenVR > indicated they would upstream them so they shouldn't get lost or have to be > maintained? Yes, we can certainly take them and apply to m-c. I've reviewed the patch, and it looks good, thanks!
Flags: needinfo?(kgilbert)
Comment on attachment 8865611 [details] Bug 1363173 Update OpenVR to build with MinGW https://reviewboard.mozilla.org/r/137238/#review146162 This looks good. We can take this in m-c before it lands upstream in OpenVR's github repo.
Attachment #8865611 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4d867f09f117 Update OpenVR to build with MinGW r=kip
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4d867f09f117
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: