Closed
Bug 1380114
Opened 7 years ago
Closed 7 years ago
Reapply MinGW build fixes to OpenVR
Categories
(Core :: WebVR, defect)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
Bug 1363173 had a patch that fixed the openvr build. They said they were going to include it in the next drop in https://github.com/ValveSoftware/openvr/pull/508 but didn't. I reminded them.
In the meantime, the original patch still applies cleanly and fixes everything, so I'm resubmitting it...
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8885419 -
Flags: review?(kgilbert)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885419 [details]
Bug 1380114 Update OpenVR to build with MinGW
https://reviewboard.mozilla.org/r/156268/#review161402
This looks good, thanks!
Hopefully the changes are accepted upstream soon.
Attachment #8885419 -
Flags: review?(kgilbert) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Updated•7 years ago
|
Assignee: nobody → tom
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/119016ae9f2b
Update OpenVR to build with MinGW r=kip
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
|
||
Comment 5•7 years ago
|
||
It appears that these changes have also been applied upstream, so this should not regress again when we update OpenVR.
You need to log in
before you can comment on or make changes to this bug.
Description
•