Closed
Bug 1365589
Opened 7 years ago
Closed 7 years ago
patcher config bumper should use stage_product to generate URLs to the candidates directory,
Categories
(Release Engineering :: Release Automation: Other, enhancement, P1)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: rail)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
bhearsum
:
review+
rail
:
checked-in+
|
Details |
Rail found this bug in early DevEdition -> Beta testing, see details in https://gist.github.com/rail/98448b412f549bcea39235d236f8b420
Reporter | ||
Updated•7 years ago
|
No longer blocks: dawn-project
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rail
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
There will be another patch to change the caller. Tweaking last things.
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8870776 [details]
Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory
https://reviewboard.mozilla.org/r/142354/#review145978
::: lib/perl/Release/Patcher/Config.pm:36
(Diff revision 2)
> $appVersion . $endOfUrl;
> }
> else {
> return 'https://www.mozilla.com/%locale%/' . $product . '/' .
> $appVersion . $endOfUrl;
> }
Will we need to change this for DevEdition?
::: lib/perl/Release/Patcher/Config.pm:79
(Diff revision 2)
> }
> -
> +
> $releaseBlock->{'locales'} = join(' ', sort (keys(%{$localeInfo})));
> -
> +
> $releaseBlock->{'completemarurl'} = 'http://' . $ftpServer . $candidateDir .
> '/update/%platform%/%locale%/' . $product . '-' . $version . '.complete.mar';
It seems confusing that stage_product only refers to directories. Not something we can fix here, but we may want to in the future.
::: release/patcher-config-bump.pl:285
(Diff revision 2)
> }
>
> my $buildStr = 'build' . $build;
> my @oldPartialVersions = keys(%{$currentUpdateObj->{'partials'}});
> my $oldPaths;
> - if ($#oldPartialVersions > 0) {
> + if ($#oldPartialVersions >= 0) {
This doesn't seem right. Isn't $oldPartialVersions[0] going to fail if the length is 0?
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8870776 [details]
Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory
https://reviewboard.mozilla.org/r/142354/#review145986
::: release/patcher-config-bump.pl:285
(Diff revision 2)
> }
>
> my $buildStr = 'build' . $build;
> my @oldPartialVersions = keys(%{$currentUpdateObj->{'partials'}});
> my $oldPaths;
> - if ($#oldPartialVersions > 0) {
> + if ($#oldPartialVersions >= 0) {
`$#var` is misleading a bit, because it refers to the last index in an array, not the size. In other words the size is equal to `$#var + 1`. I hit an issue when I used just one partial, and the last index was 0, so it didn't pass this check.
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8870776 [details]
Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory
https://reviewboard.mozilla.org/r/142354/#review145978
> Will we need to change this for DevEdition?
Maybe, if we have a separate page for it.
Reporter | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8870776 [details]
Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory
https://reviewboard.mozilla.org/r/142354/#review146004
Attachment #8870776 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8870776 [details]
Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory
https://hg.mozilla.org/build/tools/rev/174f596434c8b63880e960abb9b3b546c42280c1
Attachment #8870776 -
Flags: checked-in+
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•