Rail found this bug in early DevEdition -> Beta testing, see details in https://gist.github.com/rail/98448b412f549bcea39235d236f8b420

There will be another patch to change the caller. Tweaking last things.

Comment on attachment 8870776 [details] Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory https://reviewboard.mozilla.org/r/142354/#review145978 ::: lib/perl/Release/Patcher/Config.pm:36 (Diff revision 2) > $appVersion . $endOfUrl; > } > else { > return 'https://www.mozilla.com/%locale%/' . $product . '/' . > $appVersion . $endOfUrl; > } Will we need to change this for DevEdition? ::: lib/perl/Release/Patcher/Config.pm:79 (Diff revision 2) > } > - > + > $releaseBlock->{'locales'} = join(' ', sort (keys(%{$localeInfo}))); > - > + > $releaseBlock->{'completemarurl'} = 'http://' . $ftpServer . $candidateDir . > '/update/%platform%/%locale%/' . $product . '-' . $version . '.complete.mar'; It seems confusing that stage_product only refers to directories. Not something we can fix here, but we may want to in the future. ::: release/patcher-config-bump.pl:285 (Diff revision 2) > } > > my $buildStr = 'build' . $build; > my @oldPartialVersions = keys(%{$currentUpdateObj->{'partials'}}); > my $oldPaths; > - if ($#oldPartialVersions > 0) { > + if ($#oldPartialVersions >= 0) { This doesn't seem right. Isn't $oldPartialVersions[0] going to fail if the length is 0?

Comment on attachment 8870776 [details] Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory https://reviewboard.mozilla.org/r/142354/#review145986 ::: release/patcher-config-bump.pl:285 (Diff revision 2) > } > > my $buildStr = 'build' . $build; > my @oldPartialVersions = keys(%{$currentUpdateObj->{'partials'}}); > my $oldPaths; > - if ($#oldPartialVersions > 0) { > + if ($#oldPartialVersions >= 0) { `$#var` is misleading a bit, because it refers to the last index in an array, not the size. In other words the size is equal to `$#var + 1`. I hit an issue when I used just one partial, and the last index was 0, so it didn't pass this check.

Comment on attachment 8870776 [details] Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory https://reviewboard.mozilla.org/r/142354/#review145978 > Will we need to change this for DevEdition? Maybe, if we have a separate page for it.

Comment on attachment 8870776 [details] Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory https://reviewboard.mozilla.org/r/142354/#review146004

Comment on attachment 8870776 [details] Bug 1365589 - patcher config bumper should use stage_product to generate URLs to the candidates directory https://hg.mozilla.org/build/tools/rev/174f596434c8b63880e960abb9b3b546c42280c1