+++ This bug was initially created as a clone of Bug #1366363 +++ Firefox 57 will have compact and touch modes independently from current compact themes, but we want to keep these themes as dark/light alternatives to the default. We need to update these icons accordingly: browser/base/content/default-theme-icon.svg browser/base/content/defaultthemes/compactlight.icon.svg browser/base/content/defaultthemes/compactdark.icon.svg

Stephen, can you please provide icons for this?

If it is not too much trouble I would really like to do this, seeing as it is now a good-first-bug. Is it as simple as replacing browser/base/content/default-theme-icon.svg browser/base/content/defaultthemes/compactlight.icon.svg browser/base/content/defaultthemes/compactdark.icon.svg with Stephens updated versions?

(In reply to anting004 from comment #6) > If it is not too much trouble I would really like to do this, seeing as it > is now a good-first-bug. > Is it as simple as replacing > > browser/base/content/default-theme-icon.svg > browser/base/content/defaultthemes/compactlight.icon.svg > browser/base/content/defaultthemes/compactdark.icon.svg > > with Stephens updated versions? Yep, exactly. You might want to rename compactlight to light and compactdark to dark too (and change the references).

(In reply to Tim Nguyen :ntim from comment #7) > (In reply to anting004 from comment #6) > > If it is not too much trouble I would really like to do this, seeing as it > > is now a good-first-bug. > > Is it as simple as replacing > > > > browser/base/content/default-theme-icon.svg > > browser/base/content/defaultthemes/compactlight.icon.svg > > browser/base/content/defaultthemes/compactdark.icon.svg > > > > with Stephens updated versions? > > Yep, exactly. You might want to rename compactlight to light and compactdark > to dark too (and change the references). Good, thanks. I have fixed the images and renamed them (and any reference I could find with grep). However I found the documentation on making the patch a bit difficult to understand. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch Mentions both using hg export (or rather hg bzexport) but also reviewboard. Should I use reviewboard, mercurial or both in some way to submit a patch?

(In reply to anting004 from comment #8) > However I found the documentation on making the patch > a bit difficult to understand. > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/ > How_to_Submit_a_Patch Mentions both using hg export (or rather hg bzexport) > but also reviewboard. Sorry about that. I unsuccessfully lobbied for not telling new contributors to use reviewboard, since we're getting rid of reviewboard later this year. > Should I use reviewboard, mercurial or both in some > way to submit a patch? It's up to you...

Comment on attachment 8910165 [details] Bug 1366369 - Change default theme icons. https://reviewboard.mozilla.org/r/181662/#review187028 This looks good. Thanks!

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46ce0f1dcd55 Change default theme icons. r=dao

Build ID: 20170920220431 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.