Stephen, I interpret this to mean "add an item to about:preferences for choosing compact themes". a) Is this right? If so, b) Where do we want the setting to appear? I'd guess General. c) What UI mechanism do we want to supply to let the user choose between light/dark? d) Do we keep the items in the "Appearance" section in about:addons?

I'm not really sure how this is different from bug 1314091...

(In reply to Dão Gottwald [::dao] from comment #1) > I'm not really sure how this is different from bug 1314091... I believe UX's current plan is for there to be settings that control spacing similar to what the custom 'compact' themes do, that also have a 'touch' setting (ie more spacing than normal). This would likely imply removing compact themes as they currently exist.

Found a mockup showing at least where the switch would be: https://mozilla.invisionapp.com/share/Y7BQQLJDC#/screens/229252092_Customize_-_Empty_Overflow Not sure if this is up to date.

Spec is here: https://mozilla.invisionapp.com/share/WUBRB21NH#/screens/229252091_Customization Aaron, I would require the three icons for compact, normal and tablet mode. Can you help me with that? Thanks!

I believe Stephen is working on these icons.

I just pushed a new version, rebased and added a file I forgot to hg add. Note that this doesn't have the icons yet. Shorlander is still working on those. I'll attach another patch with tests soon.

Comment on attachment 8882036 [details] Bug 1350210 - Part 1 - Add UI density settings to customize mode. https://reviewboard.mozilla.org/r/153112/#review158544

Comment on attachment 8882237 [details] Bug 1350210 - Part 2 - Add a test for UI density settings in customize mode. https://reviewboard.mozilla.org/r/153318/#review158546 ::: commit-message-b9cf8:3 (Diff revision 1) > +Bug 1350210 - Add a test for UI density settings in customize mode. r=jaws > + > +Lines beginning with 'HG:' are removed. Please delete this line :)

Comment on attachment 8882513 [details] Bug 1350210 - Part 3 - Add uidensity icons and only show uidensity settings in Photon. https://reviewboard.mozilla.org/r/153628/#review158734 LGTM. Please add the license header to the SVGs.

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s ca48df874f4a -d 0c16e7a1a10f: rebasing 404738:ca48df874f4a "Bug 1350210 - Part 1 - Add UI density settings to customize mode. r=jaws" merging browser/base/content/browser.js merging browser/components/customizableui/CustomizeMode.jsm merging browser/locales/en-US/chrome/browser/browser.dtd merging browser/themes/shared/customizableui/customizeMode.inc.css warning: conflicts while merging browser/locales/en-US/chrome/browser/browser.dtd! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43d356910d30 Part 1 - Add UI density settings to customize mode. r=jaws https://hg.mozilla.org/integration/autoland/rev/55be54e2fce3 Part 2 - Add a test for UI density settings in customize mode. r=jaws https://hg.mozilla.org/integration/autoland/rev/7389f9de8f21 Part 3 - Add uidensity icons and only show uidensity settings in Photon. r=nhnt11

https://hg.mozilla.org/mozilla-central/rev/43d356910d30 https://hg.mozilla.org/mozilla-central/rev/55be54e2fce3 https://hg.mozilla.org/mozilla-central/rev/7389f9de8f21

Passing by note: the .properties file has been created with Windows line endings (CRLF), while they usually have Unix line endings (LF).

I can see ui "Density" settings added to "Customize" in latest Nightly 56.0a1 in 64-bit Linux. Build ID 20170706130309 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

I can see the feature implemented in latest Nightly 56.0a1 on Windows 10, 64-bit Build ID : 20170706060058 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 [bugday-20170705]

As this bug is verified as fixed in both linux(comment 29) and windows(comment 30), I am marking this as verified fixed.