Hey Carol. I got some feedback about our existing tablet UI on twitter [1]: compared to Chrome, we see display ~15 fewer characters of the url, making it hard to know what the url says. Is this something we might address with the Photon revisions? [1]: https://twitter.com/bibhasdn/status/884741684407422977

Hey Michael! Yes! We will have new Photon tool bar look. We cleaned up some UI and hopefully we can improve the readability for the URL on mobile.

^^Correct. We'll consider this issue for both mobile and tablet.

This bug fix would be focused on toolbar visual refresh on tablet.

Comment on attachment 8892391 [details] Bug 1366668 - Part 1: Duplicates awesome bar resources. https://reviewboard.mozilla.org/r/163344/#review169542 LGTM

Comment on attachment 8892392 [details] Bug 1366668 - Part 2: Apply new toolbar visual design on tablet. https://reviewboard.mozilla.org/r/163346/#review169544

Comment on attachment 8892393 [details] Bug 1366668 - Part 3: Remove forward button animation. https://reviewboard.mozilla.org/r/163348/#review169546 ::: mobile/android/app/src/photon/java/org/mozilla/gecko/toolbar/ForwardButton.java:29 (Diff revision 2) > - mBorderPath.reset(); > - final float startX; > - if (isLayoutRtl) { > - startX = 0 + mBorderWidth; > - } else { > - startX = width - mBorderWidth; > + mPath.setFillType(Path.FillType.INVERSE_EVEN_ODD); > + > + final RectF rect = new RectF(0, 0, width, height); > + final int radius = getResources().getDimensionPixelSize(R.dimen.browser_toolbar_menu_radius); > + mPath.addRoundRect(rect, radius, radius, Path.Direction.CW); > + We remove all the animation?

Comment on attachment 8892394 [details] Bug 1366668 - Part 4: Apply tint color for bookmark icon on toolbar. https://reviewboard.mozilla.org/r/163350/#review169548

Comment on attachment 8892395 [details] Bug 1366668 - Part 5: Introduce ToolbarRoundButton to support toolbar item with round rectangle background. https://reviewboard.mozilla.org/r/163352/#review169550 ::: mobile/android/app/src/australis/java/org/mozilla/gecko/toolbar/ActionButton.java:13 (Diff revision 2) > +import android.util.AttributeSet; > + > +import org.mozilla.gecko.widget.themed.ThemedImageButton; > + > +class ActionButton extends ThemedImageButton { > + The name action button is not clear. It has multiple meaning. Maybe just RoundedButton ?

Comment on attachment 8892391 [details] Bug 1366668 - Part 1: Duplicates awesome bar resources. https://reviewboard.mozilla.org/r/163344/#review169556

Comment on attachment 8892392 [details] Bug 1366668 - Part 2: Apply new toolbar visual design on tablet. https://reviewboard.mozilla.org/r/163346/#review169562

Comment on attachment 8892393 [details] Bug 1366668 - Part 3: Remove forward button animation. https://reviewboard.mozilla.org/r/163348/#review169564

Comment on attachment 8892394 [details] Bug 1366668 - Part 4: Apply tint color for bookmark icon on toolbar. https://reviewboard.mozilla.org/r/163350/#review169566

Comment on attachment 8892395 [details] Bug 1366668 - Part 5: Introduce ToolbarRoundButton to support toolbar item with round rectangle background. https://reviewboard.mozilla.org/r/163352/#review169570

Comment on attachment 8892393 [details] Bug 1366668 - Part 3: Remove forward button animation. https://reviewboard.mozilla.org/r/163348/#review169546 > We remove all the animation? Yes, in new design, forward button is always shown on tablet. You can check the spec in user story for more details. But the change here isn't directly related to animation: 1. Remove the vertical line aligned the end of forward button; 2. Add round rectangle background.

Comment on attachment 8892395 [details] Bug 1366668 - Part 5: Introduce ToolbarRoundButton to support toolbar item with round rectangle background. https://reviewboard.mozilla.org/r/163352/#review169550 > The name action button is not clear. It has multiple meaning. Maybe just RoundedButton ? I would like to change its name to ToolbarRoundButton because it should only be used in toolbar.

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1acf3c894594 Part 1: Duplicates awesome bar resources. r=nechen,walkingice https://hg.mozilla.org/integration/autoland/rev/7908675d7ec9 Part 2: Apply new toolbar visual design on tablet. r=nechen,walkingice https://hg.mozilla.org/integration/autoland/rev/bb0e8675bcc1 Part 3: Remove forward button animation. r=nechen,walkingice https://hg.mozilla.org/integration/autoland/rev/d38cc6c78193 Part 4: Apply tint color for bookmark icon on toolbar. r=nechen,walkingice https://hg.mozilla.org/integration/autoland/rev/d7cf709846ac Part 5: Introduce ToolbarRoundButton to support toolbar item with round rectangle background. r=nechen,walkingice

https://hg.mozilla.org/mozilla-central/rev/1acf3c894594 https://hg.mozilla.org/mozilla-central/rev/7908675d7ec9 https://hg.mozilla.org/mozilla-central/rev/bb0e8675bcc1 https://hg.mozilla.org/mozilla-central/rev/d38cc6c78193 https://hg.mozilla.org/mozilla-central/rev/d7cf709846ac

(In reply to Michael Comella (:mcomella) from comment #1) > Is this something we might address with the Photon revisions? > [1]: https://twitter.com/bibhasdn/status/884741684407422977 I don't think we cover that. I will file a separate bug for this

Pixel C - Android 7.1.1 Nightly 57.0a1 2017-08-09 Visual changes applied. Will follow up wit enhancement bugs as the one mentioned above.

> https://hg.mozilla.org/mozilla-central/rev/1acf3c894594 This broke hg blame/revision history for ToolbarDisplayLayout.java amongst others :-(. You should have used hg copy for one path and then hg rename for the other path, or at least used hg rename for the photon files that are going to be kept long-term.