Closed Bug 1378625 Opened 7 years ago Closed 7 years ago

(photon) Tab strip visual refresh

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox56 verified, firefox57 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- verified
firefox57 --- verified

People

(Reporter: jwu, Assigned: jwu)

References

Details

Attachments

(4 files)

Tablet_UI_A.png
(deleted), image/png
Details
Tablet_UI_B.png
(deleted), image/png
Details
Bug 1378625 - Part 1: Duplicate tab strip resources.
(deleted), text/x-review-board-request
walkingice
: review+
Details
Bug 1378625 - Part 2: Implement tab strip visual refresh for Photon.
(deleted), text/x-review-board-request
walkingice
: review+
Details
No description provided.
Attached image Tablet_UI_A.png (deleted) —
Visual spec provided by :Carol.
Attached image Tablet_UI_B.png (deleted) —
Another visual spec provided by :Carol.
Assignee: nobody → topwu.tw
Comment on attachment 8883809 [details] Bug 1378625 - Part 1: Duplicate tab strip resources. https://reviewboard.mozilla.org/r/154760/#review160198
Attachment #8883809 - Flags: review?(walkingice0204) → review+
Comment on attachment 8883810 [details] Bug 1378625 - Part 2: Implement tab strip visual refresh for Photon. https://reviewboard.mozilla.org/r/154762/#review160202
Attachment #8883810 - Flags: review?(walkingice0204) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/838e85e1079e Part 1: Duplicate tab strip resources. r=walkingice https://hg.mozilla.org/integration/autoland/rev/809f7163afab Part 2: Implement tab strip visual refresh for Photon. r=walkingice
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/838e85e1079e https://hg.mozilla.org/mozilla-central/rev/809f7163afab
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Blocks: fennec-photon-misc_ui
Any idea if there a way to verify this by pixel size not eye review?
status-firefox56: fixed → verified
status-firefox57: --- → verified
Flags: needinfo?(topwu.tw)
QA Contact: ioana.chiorean
I think the major change of this bug is that we remove the curve from tab strip. But unfortunately we don't have UI automation testing for this bug, manual testing for color change, especially in different states(focused, pressed, checked, etc) might be the only way for now. I would like to start writing some UI testing(robocop) cases for Photon recently if there are no other critical bugs coming.
Flags: needinfo?(topwu.tw)
The manual check fits the specs. ( Not sure if jqu did the UI testing TCs for this)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: