Closed Bug 1368672 Opened 7 years ago Closed 7 years ago

Zoom widget black label on black background

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Iteration:
55.7 - Jun 12
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: alice0775, Assigned: dao)

References

Details

(Keywords: regression, ux-discovery, Whiteboard: [photon-visual][p2])

Attachments

(2 files)

bug.png
(deleted), image/png
Details
Bug 1368672 - Don't set a color on toolbar buttons by default (color should be inherited) and explicitly inherit color in hover/open states for custom-styled toolbar buttons.
(deleted), text/x-review-board-request
johannh
: review+
Details
Attached image bug.png (deleted) —
I can not read Zoom % level if zoom widget is placed in tab/menubar.
Whiteboard: [photon-visual][triage]
Flags: qe-verify+
Priority: -- → P2
QA Contact: brindusa.tot
Whiteboard: [photon-visual][triage] → [photon-visual]
Whiteboard: [photon-visual] → [photon-visual][p2]
Blocks: 1368818
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 55.7 - Jun 12
Priority: P2 → P1
Comment on attachment 8874788 [details] Bug 1368672 - Don't set a color on toolbar buttons by default (color should be inherited) and explicitly inherit color in hover/open states for custom-styled toolbar buttons. https://reviewboard.mozilla.org/r/146168/#review150166 Seems good, thanks!
Attachment #8874788 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/829a5b7de7cf Don't set a color on toolbar buttons by default (color should be inherited) and explicitly inherit color in hover/open states for custom-styled toolbar buttons. r=johannh
https://hg.mozilla.org/mozilla-central/rev/829a5b7de7cf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this Bug on Nightly 55.0a1 (2017-05-30) on Windows 10, 64 Bit! The bug's fix is now verified on latest Nightly 55.0a1 Build ID : 20170608030205 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170607]
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
Depends on: 1437564
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: