Mockup: https://people-mozilla.org/~shorlander/projects/photon/Mockups/windows-10.html

Sorry for the somewhat messy patch. I could have used caption-buttons.svg#*-white to adjust to the new title bar color, but I thought now would be a good time for some refactoring and then things got a bit out of control...

Comment on attachment 8871892 [details] Bug 1367384 - Make the title bar dark by default on Windows 10 and refactor caption button icons. https://reviewboard.mozilla.org/r/143424/#review147592 Great, thanks! Just a couple of minor things. ::: browser/themes/windows/browser-aero.css:119 (Diff revision 1) > - #titlebar-close:hover { > - list-style-image: url(chrome://browser/skin/caption-buttons.svg#close-white); > } > > + .titlebar-button:-moz-lwtheme { > + -moz-context-properties: unset; This doesn't really have any effect since the stroke values are hardcoded anyway, right? Any reason for keeping this rule around? ::: browser/themes/windows/window-controls/maximize-highcontrast.svg:4 (Diff revision 1) > +<!-- This Source Code Form is subject to the terms of the Mozilla Public > + - License, v. 2.0. If a copy of the MPL was not distributed with this > + - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> > +<svg width="12" height="12" xmlns="http://www.w3.org/2000/svg"> Missing a shape-rendering="crispEdges"? Assuming that it's still necessary. ::: browser/themes/windows/window-controls/maximize.svg:4 (Diff revision 1) > +<!-- This Source Code Form is subject to the terms of the Mozilla Public > + - License, v. 2.0. If a copy of the MPL was not distributed with this > + - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> > +<svg width="12" height="12" xmlns="http://www.w3.org/2000/svg"> shape-rendering="crispEdges"? ::: browser/themes/windows/window-controls/restore-themes.svg:7 (Diff revision 1) > + - License, v. 2.0. If a copy of the MPL was not distributed with this > + - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> > +<svg width="12" height="12" xmlns="http://www.w3.org/2000/svg" shape-rendering="crispEdges" fill="none" stroke="white"> > + <path stroke="black" stroke-width="3.6" stroke-opacity=".75" d="M2,4 l 6,0 l 0,6 l -6,0z M2.5,1.5 l 8,0 l 0,8"/> > + <rect stroke-width="1.9" x="2" y="4" width="6" height="6"/> > + <polyline stroke-width=".9" points="3.5,1.5 10.5,1.5 10.5,8.5" class="restore-background-window"/> I think you can remove class=restore-background-window

(In reply to Johann Hofmann [:johannh] from comment #3) > ::: browser/themes/windows/browser-aero.css:119 > (Diff revision 1) > > - #titlebar-close:hover { > > - list-style-image: url(chrome://browser/skin/caption-buttons.svg#close-white); > > } > > > > + .titlebar-button:-moz-lwtheme { > > + -moz-context-properties: unset; > > This doesn't really have any effect since the stroke values are hardcoded > anyway, right? Any reason for keeping this rule around? Yes, it tells Gecko that it doesn't need to bother forwarding context properties in the first place. It's supposed to be cheaper.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f9541bc8ef95 Make the title bar dark by default on Windows 10 and refactor caption button icons. r=johannh

I have seen the feature being implemented with latest Nightly 55.0a1 on Windows 10 (64 bit). This bug's fix is now verified in Latest Nightly. Build ID : 20170531030204 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday 20170531]