Closed
Bug 1369523
Opened 7 years ago
Closed 7 years ago
get_output_from_command is reading the output file even if return_type != 'output' and silent=True
Categories
(Release Engineering :: Applications: MozharnessCore, enhancement)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox55 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
When return_type != 'output' and silent=True, we can skip reading the output file.
|
Assignee | |
Comment 1•7 years ago
|
||
It doesn't actually block bug 1367763, but it's nice to have to spare some resources.
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8874132 [details] [diff] [review]
Patch
makes sense.
Attachment #8874132 -
Flags: review?(aki) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a45f5c74d5a
Avoid reading output file in get_output_from_command when it is not needed. r=aki
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•