UK92 Reporter
	Description • 7 years ago

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170607030206

Steps to reproduce:

There is an ugly gap about 3.5px between titlebar buttons and navigation bar but only when window is maximize.

	Dão Gottwald [:dao]
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8875426 [details]
Bug 1370989 - Remove gap between titlebar buttons and navigation toolbar

https://reviewboard.mozilla.org/r/146848/#review151262

::: browser/base/content/browser-tabsintitlebar.js:210
(Diff revision 1)
>  
>        // Next, we calculate how much we need to stretch the titlebar down to
>        // go all the way to the bottom of the tab strip, if necessary.
>        let tabAndMenuHeight = fullTabsHeight + fullMenuHeight;
>  
> +      if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") && !menuHeight) {

This would be wrong for when there's space above tabs, i.e. in Firefox 55 and 56. We'll need to wrap this in a MOZ_PHOTON_THEME ifdef.

If you update your patch, could you please post it to bug 1185482? Thanks!