Closed
Bug 1370989
Opened 7 years ago
Closed 7 years ago
Windows 10: Ugly gap between titlebar buttons and navigation bar
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1185482
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | affected |
People
(Reporter: urbankrajnc92, Unassigned)
Details
Attachments
(2 files)
Gap between
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170607030206
Steps to reproduce:
There is an ugly gap about 3.5px between titlebar buttons and navigation bar but only when window is maximize.
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
Whiteboard: [photon-visual]
| Comment hidden (mozreview-request) |
Attachment #8875426 -
Flags: review?(dao+bmo)
|
||
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual] [triage]
|
||
Updated•7 years ago
|
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8875426 [details]
Bug 1370989 - Remove gap between titlebar buttons and navigation toolbar
https://reviewboard.mozilla.org/r/146848/#review151262
::: browser/base/content/browser-tabsintitlebar.js:210
(Diff revision 1)
>
> // Next, we calculate how much we need to stretch the titlebar down to
> // go all the way to the bottom of the tab strip, if necessary.
> let tabAndMenuHeight = fullTabsHeight + fullMenuHeight;
>
> + if (AppConstants.isPlatformAndVersionAtLeast("win", "10.0") && !menuHeight) {
This would be wrong for when there's space above tabs, i.e. in Firefox 55 and 56. We'll need to wrap this in a MOZ_PHOTON_THEME ifdef.
If you update your patch, could you please post it to bug 1185482? Thanks!
Attachment #8875426 -
Flags: review?(dao+bmo) → review-
|
|
||
Updated•7 years ago
|
No longer blocks: 1185482
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Whiteboard: [photon-visual] [triage]
You need to log in
before you can comment on or make changes to this bug.
Description
•