Mike Conley (:mconley) (:⚙️) Assignee
	Description • 7 years ago

I have screenshots coming from the Linux Taskcluster builds, but I think mozilla-tests/config.py in our BuildBot config needs to be modified if I want the MOCHITEST_BC_SCREENSHOTS job to run for OS X and Windows on Cedar.

For context, the screenshots tests will allow us to ensure that we're not regressing the non-Photon theme while we develop Photon on Nightly.

	Matthew N. [:MattN]
	Comment 1 • 7 years ago

(In reply to Mike Conley (:mconley) from comment #0)
> I have screenshots coming from the Linux Taskcluster builds, but I think
> mozilla-tests/config.py in our BuildBot config needs to be modified if I
> want the MOCHITEST_BC_SCREENSHOTS job to run for OS X and Windows on Cedar.

FWIW, some of the Windows platforms are now running on TaskCluster so those should be preferred over the BB jobs since BB is eventually going away. The TC images just need to be vetted and then I can make sure my server code (on Github) fetches and compares them instead of BB.

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 2 • 7 years ago

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #1)
> FWIW, some of the Windows platforms are now running on TaskCluster

That's just Win 64, right?

	Matthew N. [:MattN]
	Comment 3 • 7 years ago

No, make sure you enable Tier 3:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=464b2a3c25aa1065760d9ecbb0870bca4a66c62e&filter-searchStr=ss&filter-tier=1&filter-tier=2&filter-tier=3

Windows 7 opt 	
Windows 7 VM opt 	
Windows 8 x64 opt 	
Windows 10 x64 opt 	
Windows 10 x64 VM opt

	Matthew N. [:MattN]
	Comment 4 • 7 years ago

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #3)
> Windows 8 x64 opt 	

This one is only BB, the others are TC and/or BB

	Matthew N. [:MattN]
	Comment 5 • 7 years ago

It looks like you didn't add cedar to the arrays at https://dxr.mozilla.org/mozilla-central/rev/416c3c8c4b3db9ba96a103ce7820c9a140a3051d/taskcluster/ci/test/tests.yml#634,641-642

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 6 • 7 years ago

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #5)
> It looks like you didn't add cedar to the arrays at
> https://dxr.mozilla.org/mozilla-central/rev/
> 416c3c8c4b3db9ba96a103ce7820c9a140a3051d/taskcluster/ci/test/tests.yml#634,
> 641-642

Ah hah! Thanks!

	Mike Conley (:mconley) (:⚙️) Assignee
	Comment 7 • 7 years ago

Hey MattN, I landed this change on cedar:

https://hg.mozilla.org/projects/cedar/rev/a2e5b530b538efc2e66623e5d1cf2a311c532a39

But I'm still not seeing screenshot builds for Windows... any idea what I'm missing?

	Matthew N. [:MattN]
	Comment 8 • 7 years ago

Unless you manually added the job… I see it working on https://treeherder.mozilla.org/#/jobs?repo=cedar&revision=126ff8dc1f0bfb6b371d263b8ea693ae3c725f5e&filter-searchStr=screenshot&filter-tier=1&filter-tier=2&filter-tier=3 so my theory is that SETA is deciding it's not necessary to run it (because it never turns orange). SETA is disabled on m-c and Try so that problem doesn't exist on the other repos. I guess you need to disable SETA for the job. See also bug 1342819.

Joel, do you also think SETA is the issue?

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 9 • 7 years ago

screenshots runs on buildbot and some on taskcluster.  For buildbot, SETA applies to autoland, inbound, and graphics branches:
https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla-tests/config_seta.py#10

for taskcluster it is just autoland and inbound:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/util/seta.py#11

I only see the buildbot stuff scheduled on try and m-c:
https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla-tests/config.py#2683

on Cedar, I do not see taskcluster builds for windows, and we have it defined in taskcluster to run ss on windows/opt- I see a lot of other TC stuff on Cedar, not sure why the builds are missing though.

	Matthew N. [:MattN]
	Comment 10 • 7 years ago

(In reply to Mike Conley (:mconley) - Digging out of needinfo / review backlog. from comment #7)
> Hey MattN, I landed this change on cedar:
> 
> https://hg.mozilla.org/projects/cedar/rev/
> a2e5b530b538efc2e66623e5d1cf2a311c532a39
> 
> But I'm still not seeing screenshot builds for Windows... any idea what I'm
> missing?

Porting https://hg.mozilla.org/integration/mozilla-inbound/rev/aaa4ae876a53 to Cedar should help with some things

	Mihai Tabara [:mtabara]⌚️GMT
	Comment 11 • 7 years ago

Found in triaging: is there anything else left to be done here? Trying to understand if this is the right component.

Note explaining the priority level: P5 doesn't mean we've lowered the priority, but the contrary. However, we're aligning these levels to the buildduty quarterly deliverables, where P1-P3 are taken by our daily waterline KTLO operational tasks.

	Johann Hofmann [:johannh]
	Comment 12 • 7 years ago

I don't think this applies anymore.