Open Bug 1375493 Opened 7 years ago Updated 2 years ago

Consider not flushing from HTMLEditor::GetAbsolutelyPositionedSelectionContainer()

Categories

(Core :: DOM: Editor, defect, P2)

defect

Tracking

()

People

(Reporter: ehsan.akhgari, Assigned: smaug)

References

Details

Attachments

(1 file)

I think this function can probably be switched to use nsComputedDOMStyle::GetStyleContextNoFlush() to avoid a style flush. This means that it could be using relatively stale style information, which is currently probably an issue given where this is called <https://searchfox.org/mozilla-central/rev/ae94cfb36d804727dfb38f2750bfcaab4621df6e/editor/libeditor/HTMLEditorObjectResizer.cpp#92>, but some testing may be needed. It may be a good idea to somehow move this to happen after the style flush that happens as part of the refresh driver tick.
That is by bug 47066...
mozilla::HTMLEditor::GetAbsolutelyPositionedSelectionContainer checks whether current element has position:aboslute. But does it require computedstyle?
Priority: -- → P2
We probably could just move CheckSelectionStateForAnonymousButtons to be called around tick time. Less hacky than use possibly stale position information.
Assignee: nobody → bugs
Depends on: 1435646
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: