Hi Mike, Could you help review the patch? Thank you.

Comment on attachment 8890240 [details] Bug 1377167 - Update font size, font color, and background color to match the Photon preferences visual refresh spec. https://reviewboard.mozilla.org/r/161356/#review169554 Evan, please add MOZ_PHOTON_PREFERENCES flag when introducing new Photon style changes. #ifdef MOZ_PHOTON_PREFERENCES in XUL %ifdef MOZ_PHOTON_PREFERENCES in CSS You can reference my patch https://reviewboard.mozilla.org/r/160914/diff/23/ as well. Thanks

Thanks, Ricky. Updated.

Comment on attachment 8890240 [details] Bug 1377167 - Update font size, font color, and background color to match the Photon preferences visual refresh spec. https://reviewboard.mozilla.org/r/161356/#review169926 I didn't do a pixel-by-pixel comparison with the spec, but it certainly looks right from a quick pass. Code looks good too - just one nit below. Thanks! ::: browser/themes/shared/incontentprefs/preferences.inc.css:768 (Diff revision 7) > +.category-name { > + font-size: 1.45rem; > + color: #0c0c0d; > +} > + > +.category, .category:hover, .category[selected] { Nit: I think in general, we like to break up separate selectors over separate lines. Can you break these up over 3 lines, please?

Comment on attachment 8890240 [details] Bug 1377167 - Update font size, font color, and background color to match the Photon preferences visual refresh spec. https://reviewboard.mozilla.org/r/161356/#review170208 ::: browser/themes/shared/incontentprefs/preferences.inc.css:768 (Diff revision 7) > +.category-name { > + font-size: 1.45rem; > + color: #0c0c0d; > +} > + > +.category, .category:hover, .category[selected] { Sure, let's do it.

Updated patch to fix font-weight issues. Let's land it after the try[1] is good. [1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2eeec89f035f

The try is good. Let's land it.

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3910ce15bbb Update font size, font color, and background color to match the Photon preferences visual refresh spec. r=mconley

What about the other in-content pages? Shouldn't they fit too?

According to my understanding, other in-content pages will be updated except about:addons page.

(In reply to Evan Tseng [:evanxd] from comment #23) > According to my understanding, other in-content pages will be updated except > about:addons page. Black text 'Inactive tab' and 'Blue text - Active tab' is hard to read on the dark gray background. Those people with vision impairments are likely to have issues. This IMO needs to be re-thought about not changing the about:addons page

Build ID: 20170829100404 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.