Closed Bug 1377202 Opened 7 years ago Closed 7 years ago

Bookmark icon in location bar not visible with Compact Dark Theme (and potentially dark OS themes and/or other dark lightweight themes)

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Product:
Firefox
Component:
Toolbars and Customization
Version:
56 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Iteration:
56.2 - Jul 10
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- verified

People

(Reporter: lightnin9, Assigned: Gijs)

References

Details

(Keywords: nightly-community, regression, Whiteboard: [photon-structure][fixed by bug 1377165])

Attachments

(1 file)

example image for barely visible star icon
(deleted), image/png
Details
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Build ID: 20170629030206 Steps to reproduce: - updated to most recent nightly release "56.0a1 (2017-06-29)(64-Bit)" - selected "Compact Dark" theme Actual results: Bookmark "star" icon is barely visible in the address bar (black icon on VERY dark background) Expected results: Would have expected the bookmark icon to change color to something lighter. The light grey color of the reading mode icon would probably fit rather well.
Confirmed on Linux with the compact dark theme, the icon is not visible
Status: UNCONFIRMED → NEW
Component: Untriaged → Toolbars and Customization
Ever confirmed: true
Keywords: nightly-community
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1352120
Status: NEW → ASSIGNED
Iteration: --- → 56.2 - Jul 10
Keywords: regression
Priority: -- → P1
Summary: Bookmark icon barely visible with Compact Dark Theme in version 56.0a1 (2017-06-29) → Bookmark icon in location bar not visible with Compact Dark Theme (and potentially dark OS themes and/or other dark lightweight themes)
Whiteboard: [photon-structure]
Flags: qe-verify+
QA Contact: gwimberly
Depends on: 1377165
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Whiteboard: [photon-structure] → [photon-structure][fixed by bug 1377165]
I can confirm it's fixed in Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0 ID:20170704100254 CSet: fef489e8c2a193dde885adc48deb74cc883a5881
Verified on Windows, Mac, and Linux.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
Target Milestone: --- → Firefox 56
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: