Closed Bug 1377227 Opened 7 years ago Closed 7 years ago

Bookmark and Page Action icons in the location bar are too dark

Categories

(Firefox :: Theme, defect, P1)

56 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 56
Iteration:
56.2 - Jul 10
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- verified

People

(Reporter: Virtual, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: nightly-community, ux-consistency, Whiteboard: [photon-structure] [fixed by patch from bug #1377165])

Attachments

(2 files)

Attached image address bar.png (deleted) —
Standardize buttons icons colors styles in address bar. "☆" and "•••" buttons are too eye catchy now, as they are too black. So either make them less black or make other icons also that black, so all buttons icons will have consistent color style
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Whiteboard: [photon][triage] → [photon] [triage]
Whiteboard: [photon] [triage] → [photon-visual] [triage]
Actually, the structure team should probably own this ourselves given we're the ones adding most of these items, unless the visual team particularly wants to do this work. Dão, can you clarify how you're doing the colours in the navbar? It seems the design says to use #0c0c0d (#f9f9fa on inverted themes) on all of these items, but with 80% opacity in the navbar and 60% in the location bar. But the code I'm finding uses opaque colours that don't seem to match this ( https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/toolbarbutton-icons.inc.css#2-4 ). Is the design out of date, does it not match the live mocks, or am I just misunderstanding how it works (is there opacity applied somewhere else that I'm not seeing?) - and most importantly, how do we integrate the page action icons into however this system works?
Blocks: 1352697
Flags: needinfo?(dao+bmo)
Whiteboard: [photon-visual] [triage] → [photon-structure]
The inversion logic is based on the toolbar's text color, which can be different from the location bar's text color. This means that you should not use --toolbarbutton-icon-fill here and you shouldn't hardcode #0c0c0d either. Since the difference between #0c0c0d (gray with blue shift) and #0c0c0c (real gray) is negligible, you should use currentColor with reduced opacity or fill-opacity.
Flags: needinfo?(dao+bmo)
Component: Toolbars and Customization → Theme
Summary: Standardize buttons icons colors styles in address bar → Bookmark and Page Action icons in the location bar are too dark
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [photon-structure] → [photon-structure] [triage]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → RESOLVED
Iteration: --- → 56.2 - Jul 10
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [photon-structure] [triage] → [photon-structure][fixed by bug 1377165]
Flags: qe-verify+
Priority: -- → P1
QA Contact: gwimberly
I'm marking this bug as VERIFIED, as patch from bug #1377165 fixed also this issue, starting from Mozilla Firefox Nightly 56.0a1 (2017-07-04). Thanks.
Status: RESOLVED → VERIFIED
Depends on: 1377165
Whiteboard: [photon-structure][fixed by bug 1377165] → [photon-structure] [fixed by patch from bug #1377165]
Flags: qe-verify+
Target Milestone: --- → Firefox 56
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: