Closed
Bug 1378215
Opened 7 years ago
Closed 7 years ago
browser_parsable_css.js permafails on cedar (presumably will perma-fails once 56 merges to beta)
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: Gijs, Assigned: johannh)
References
Details
Attachments
(1 file)
Hard to spot but behind the orange from bug 1378163 there is some 'inverse' orange - files that we don't package but that are referenced from non-ifdef'd CSS. Specifically:
[task 2017-07-04T15:06:21.466571Z] 15:06:21 INFO - Buffered messages finished
[task 2017-07-04T15:06:21.468745Z] 15:06:21 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://browser/skin/customizableui/density-normal.svg referenced from chrome://browser/skin/browser.css -
[task 2017-07-04T15:06:21.470486Z] 15:06:21 INFO - Stack trace:
[task 2017-07-04T15:06:21.472343Z] 15:06:21 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:340
[task 2017-07-04T15:06:21.477831Z] 15:06:21 INFO - Not taking screenshot here: see the one that was previously logged
[task 2017-07-04T15:06:21.483871Z] 15:06:21 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://browser/skin/customizableui/density-compact.svg referenced from chrome://browser/skin/browser.css -
[task 2017-07-04T15:06:21.485777Z] 15:06:21 INFO - Stack trace:
[task 2017-07-04T15:06:21.487722Z] 15:06:21 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:340
[task 2017-07-04T15:06:21.496211Z] 15:06:21 INFO - Not taking screenshot here: see the one that was previously logged
[task 2017-07-04T15:06:21.499797Z] 15:06:21 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://browser/skin/customizableui/density-touch.svg referenced from chrome://browser/skin/browser.css -
Reporter | ||
Comment 1•7 years ago
|
||
Johann, could you help with this? :-)
Blocks: 1350210
Flags: needinfo?(jhofmann)
Assignee | ||
Comment 2•7 years ago
|
||
Hah, I was wondering if not putting that CSS behind MOZ_PHOTON_THEME would cause something to explode. Sorry for that. I'll fix it of course.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Above was non-Photon, this one is with Photon enabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc7f8d2c11784dc06bc21e5e37edb15802f2448e
Reporter | ||
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8884269 [details]
Bug 1378215 - Put references to Photon-only images behind Photon compile flags.
https://reviewboard.mozilla.org/r/155216/#review160246
Attachment #8884269 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 7•7 years ago
|
||
I think the non-Photon try has failures because I didn't disable structure. I'll go ahead and land this.
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa7711419df0
Put references to Photon-only images behind Photon compile flags. r=Gijs
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•