Closed
Bug 1379123
Opened 7 years ago
Closed 7 years ago
Sort UI density options by density
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Firefox
Toolbars and Customization
Tracking
()
People
(Reporter: dao, Assigned: johannh)
References
Details
(Whiteboard: [photon-visual][p4])
Attachments
(1 file)
Current order of options is Normal, Compact, Touch. I think Compact, Normal, Touch would make more sense.
Comment 2•7 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #0)
> Current order of options is Normal, Compact, Touch. I think Compact, Normal,
> Touch would make more sense.
Is that from top to bottom? I like the suggestion but I wonder if we should sort by "size" by placing the larger option at the top:
Touch
Normal
Compact
Flags: needinfo?(abenson)
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P2
QA Contact: brindusa.tot
Whiteboard: [photon-visual][triage] → [photon-visual]
Reporter | ||
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual][p4]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•7 years ago
|
||
I think Dão's suggestion makes more sense, because the Tablet Mode checkbox works well when it's below the Touch mode menuitem. https://mozilla.invisionapp.com/share/ENBBK0F9U#/screens/229252105
Do you agree, Aaron?
Flags: needinfo?(abenson)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8886149 [details]
Bug 1379123 - Sort UI density options by density.
https://reviewboard.mozilla.org/r/156948/#review162046
Iteration: 56.3 - Jul 24 → ---
Attachment #8886149 -
Flags: review?(dao+bmo) → review+
Priority: P1 → P2
Updated•7 years ago
|
Iteration: --- → 56.3 - Jul 24
Priority: P2 → P1
Updated•7 years ago
|
Iteration: --- → 56.3 - Jul 24
Priority: P2 → P1
Comment 6•7 years ago
|
||
Ah, that's a fair point. I can get behind that! (Compact, Normal, Touch)
Flags: needinfo?(abenson)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30aea103f6b4
Sort UI density options by density. r=dao
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•7 years ago
|
QA Contact: brindusa.tot → ovidiu.boca
Comment 9•7 years ago
|
||
I verified this issue on Windows 10 and Windows 7 and Windows 10 on Surface Pro 2 with the latest Nightly 57.0a1(2017-08-16) and I can confirm the fix, the current order is Compact, Normal, Touch.
You need to log in
before you can comment on or make changes to this bug.
Description
•