Closed
Bug 1380294
Opened 7 years ago
Closed 7 years ago
[Firefox Notes] Formatting option tooltips are wrongly displayed on the latest Nightly
Categories
(WebExtensions :: General, defect, P1)
Tracking
(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 verified, firefox57 verified)
VERIFIED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | verified |
firefox57 | --- | verified |
People
(Reporter: emilpasca, Assigned: kmag)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
image/gif
|
Details | |
(deleted),
image/gif
|
Details | |
(deleted),
text/x-review-board-request
|
aswan
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
[Affected versions]:
- Nightly 56.0a1, Build ID: 20170711030203
[Affected Platforms]:
- All Windows
[Prerequisites]:
- Have a Firefox profile with the latest Notes add-on (version 1.5-dev) installed.
[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Hover the formatting option buttons("Bold","Italic","Ordered list", etc.) from "Notes" sidebar.
3. Observe the displayed tooltips.
[Expected result]:
- The tooltips are displayed correctly below the corresponding buttons.
[Actual result]:
- The tooltips appear very far to the right of the button.
[Regression]:
With Nightly 56.0a1, Build ID: 20170710030203, the issue is not reproducible.
Last good revision: 392ed89ec2730a48d10b1cec741e86a242d28aa3
First bad revision: a625a2e9b3333a8e76982ea65f077cfded6ac224
Pushlog: https://goo.gl/N1DhXR
[Notes]:
- Attached a screen recording of the issue.
Refs https://github.com/mozilla/notes/issues/136
Kris, can you please have a look at this?
Comment 1•7 years ago
|
||
Sounds like might be related to oop.
Blocks: webext-oop
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → DUPLICATE
Fixed in the duplicate.
On 2nd look, it may not have been fixed in bug 1379508. I've reopened that bug.
This issue is still reproducing, checked on Firefox 56.0a1 (2017-07-24) under Win 7 64-bit and Ubuntu Ubuntu 16.04 LTS 32-bit.
Please see the attached video.
Updated•7 years ago
|
Flags: needinfo?(kmaglione+bmo)
Comment 8•7 years ago
|
||
Is there a build of this somewhere as an xpi that we can test?
Flags: needinfo?(emil.pasca)
Comment 9•7 years ago
|
||
I grabbed a build from https://github.com/mozilla/notes/releases. No tooltips were showing up, so I changed a button to <button class="ql-bold" title="Bold"></button> and the same problem seems to be reproducing - the tooltip appears way over on the right. It does not reproduce with oop turned off.
Flags: needinfo?(emil.pasca)
Priority: -- → P1
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8892657 [details]
Bug 1380294: Anchor non-tab tooltips to the correct remote browser.
https://reviewboard.mozilla.org/r/163644/#review169038
Attachment #8892657 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 12•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3afb9a45faebc2e32591f881943fabae4f84b19a
Bug 1380294: Anchor non-tab tooltips to the correct remote browser. r=aswan
Comment 13•7 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Comment 14•7 years ago
|
||
Comment on attachment 8892657 [details]
Bug 1380294: Anchor non-tab tooltips to the correct remote browser.
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1357486
[User impact if declined]: This causes confusing and unexpected UI behavior for tooltips in several extension UI elements.
[Is this code covered by automated tests?]: For tooltips in general, yes, but not yet for the positioning of tooltips in the particular places that this bug addresses.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: STR are listed in previous comments.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This change is very simple, and confined to the placement of OOP tooltips. The worst case regression would be tooltips not showing up.
[String changes made/needed]: None.
Attachment #8892657 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
Comment 15•7 years ago
|
||
Hi Emil, could you help verify if this issue was fixed as expected on the latest Nightly build? Thanks.
Flags: needinfo?(emil.pasca)
Reporter | ||
Comment 16•7 years ago
|
||
I can confirm that the issue is no longer reproducible on Windows 7 x64 and Windows 10 x64 with the latest Nightly 57.0a1 build ID: 20170808114032.
Status: RESOLVED → VERIFIED
Flags: needinfo?(emil.pasca)
Comment 17•7 years ago
|
||
Comment on attachment 8892657 [details]
Bug 1380294: Anchor non-tab tooltips to the correct remote browser.
Fix a regression and was verified. Beta56+. Should be in 56 beta 2.
Attachment #8892657 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 18•7 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 19•7 years ago
|
||
I can confirm that the issue is no longer reproducible on Windows 10 x64 with the latest Beta 56.0b2 build ID: 20170810180547.
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•