Open
Bug 1190679
(webext-oop)
Opened 9 years ago
Updated 1 year ago
[meta] Run WebExtensions out of process
Categories
(WebExtensions :: General, enhancement, P3)
WebExtensions
General
Tracking
(Not tracked)
NEW
mozilla45
People
(Reporter: billm, Unassigned)
References
(Depends on 14 open bugs, Blocks 2 open bugs)
Details
(Keywords: meta, perf, Whiteboard: triaged, [we-enterprise])
Besides setting the remote=true attribute on the browser elements used for extensions, we'll need to move the API-injected code to the other process (via content scripts or something). We'll also need platform support to ensure that all the <browser> elements for a given add-on run in the same process.
Reporter | ||
Updated•9 years ago
|
Priority: -- → P2
Comment 1•9 years ago
|
||
Bill, is this bug about running the background pages OOP or more than that?
Reporter | ||
Comment 2•9 years ago
|
||
There are a couple different kinds of pages that would need to run out of process:
- background page
- browserAction popup page
- any tabs that are showing moz-extension: URIs
We have to move them all together since they can get references to each other's windows.
Reporter | ||
Updated•9 years ago
|
Component: Extension Compatibility → WebExtensions
Product: Firefox → Toolkit
Comment 3•9 years ago
|
||
I'd like to work on the extensions; assigning this to myself. :)
Assignee: nobody → echen
Reporter | ||
Comment 4•9 years ago
|
||
I think this could be a lot of work, including some platform changes. Do you have a plan for this Edgar? Otherwise we should discuss the approach.
Flags: needinfo?(echen)
Summary: Run open extensions out of process → Run WebExtensions out of process
Comment 5•9 years ago
|
||
I believe this is a huge work. And I am still in study stage (trying to get whole picture from bug 1175770). Do you have any suggestion where we should start with? Thank you.
Flags: needinfo?(echen) → needinfo?(wmccloskey)
Reporter | ||
Comment 6•9 years ago
|
||
Sorry it took me a while to get to this.
The actual extension code will run in a content process. We'll do this using remote <browser> elements (and maybe remote moz-browser elements on b2g). The main process will load a process script into the extension process and the two processes will communicate using the process message manager.
We'll need some platform support to ensure that all these <browser> elements run in the same extension process. That could be an attribute on the <browser> DOM element. The <browser> elements that will need this attribute are for the background page, the browser action, and any page loaded with a moz-extension URI. For the latter, we'll need special handling in E10SUtils.jsm [1] on desktop to ensure that the page loads in the right process. I'm not sure how to handle that on b2g.
The ext-*.js scripts will have to be split into main process scripts and an extension process scripts. They'll communicate using the process message manager. Most API functions will probably just be forwarded to the main process, with their arguments sent using structured clone. However, there are some APIs that pass functions, so we'll have to do something special there.
The webRequest API will also need special handling. Right now it requires the request handlers to be synchronous, which won't be the case when the extension is OOP. I think we'll have to make it suspend the request until the extension makes a decision about whether to block.
I think the best way to get started here is to start using a non-remote browser element for the background page. Right now the code is loaded directly into a windowless docshell. If that works, then we can start moving some of the ext-*.js code to process scripts (as well as some of the related code in Extension.jsm, such as GlobalManager).
[1] http://mxr.mozilla.org/mozilla-central/source/browser/modules/E10SUtils.jsm#62
Flags: needinfo?(wmccloskey)
Comment 7•9 years ago
|
||
(In reply to Bill McCloskey (:billm) from comment #6)
> Sorry it took me a while to get to this.
>
> The actual extension code will run in a content process. We'll do this using
> remote <browser> elements (and maybe remote moz-browser elements on b2g).
> The main process will load a process script into the extension process and
> the two processes will communicate using the process message manager.
>
> We'll need some platform support to ensure that all these <browser> elements
> run in the same extension process. That could be an attribute on the
> <browser> DOM element. The <browser> elements that will need this attribute
> are for the background page, the browser action, and any page loaded with a
> moz-extension URI. For the latter, we'll need special handling in
> E10SUtils.jsm [1] on desktop to ensure that the page loads in the right
> process. I'm not sure how to handle that on b2g.
On b2g we had a need to run different apps in the same process (for Tarako) and we did that by adding a parentapp attribute on <iframe mozbrowser>. The ContentParent uses this attribute at http://mxr.mozilla.org/mozilla-central/source/dom/ipc/ContentParent.cpp#1264
> I think the best way to get started here is to start using a non-remote
> browser element for the background page. Right now the code is loaded
> directly into a windowless docshell. If that works, then we can start moving
> some of the ext-*.js code to process scripts (as well as some of the related
> code in Extension.jsm, such as GlobalManager).
Right, that's what I'm fixing in bug 1198970 as part of getting webRequest to work.
Updated•9 years ago
|
Comment 8•9 years ago
|
||
Unassigning myself as I am not able to work on this in short term.
Assignee: echen → nobody
Updated•9 years ago
|
Flags: blocking-webextensions+
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → wmccloskey
Updated•9 years ago
|
Iteration: --- → 45.1 - Nov 16
Updated•9 years ago
|
OS: Unspecified → All
Hardware: Unspecified → All
Version: 34 Branch → unspecified
Updated•9 years ago
|
Iteration: 45.1 - Nov 16 → 45.2 - Nov 30
Updated•9 years ago
|
Target Milestone: --- → mozilla45
Updated•9 years ago
|
Whiteboard: triaged
Comment 9•9 years ago
|
||
After chatting with Bill, we decided to move this to post 48, but before we implement any APIs beyond Chromes implementation.
Flags: blocking-webextensions+ → blocking-webextensions-
Updated•8 years ago
|
Alias: webext-oop
Updated•8 years ago
|
webextensions: --- → +
Updated•8 years ago
|
Whiteboard: triaged → triaged, [we-enterprise]
Updated•8 years ago
|
Assignee: wmccloskey → kmaglione+bmo
Updated•8 years ago
|
Whiteboard: triaged, [we-enterprise] → triaged, [we-enterprise][qf:meta]
Updated•8 years ago
|
Blocks: webext-perf
Updated•8 years ago
|
Whiteboard: triaged, [we-enterprise][qf:meta] → triaged, [we-enterprise][qf:meta][qf:p1]
Updated•7 years ago
|
Depends on: webextensions-startup
Depends on: CVE-2017-7816
Updated•7 years ago
|
No longer depends on: webextensions-startup
Comment 10•7 years ago
|
||
Taking off webextensions+ and qf:p1. We've got out of process running on Windows which is the main quantum flow target. We'd like to get out of process working on OS X and Linux, but those will likely come after 57.
The bug for turning on out of process on windows was bug 1357486.
webextensions: + → ---
Whiteboard: triaged, [we-enterprise][qf:meta][qf:p1] → triaged, [we-enterprise][qf:meta]
Comment 11•7 years ago
|
||
I also had a problem with <select> drop down menu showing but not working in sidebar.
Tomislav suggested setting 'extensions.webextensions.remote' to false and after reloading the extension, the drop down menu worked fine in the sidebar.
I am using FF56.0b1
The default 'extensions.webextensions.remote' is true and users will not be expected to change it.
Updated•7 years ago
|
Priority: P1 → --
Updated•7 years ago
|
Updated•6 years ago
|
Product: Toolkit → WebExtensions
Comment 13•6 years ago
|
||
Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958
Component: Untriaged → General
Updated•6 years ago
|
Assignee: kmaglione+bmo → nobody
Updated•6 years ago
|
Summary: Run WebExtensions out of process → [meta] Run WebExtensions out of process
Updated•5 years ago
|
Priority: P2 → P3
Comment 14•5 years ago
|
||
I suppose that bug 1513656 should be considered a regression.
Updated•3 years ago
|
Performance Impact: --- → ?
Whiteboard: triaged, [we-enterprise][qf:meta] → triaged, [we-enterprise]
Updated•3 years ago
|
Performance Impact: ? → ---
Comment 15•2 years ago
|
||
In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.
Severity: major → --
Updated•2 years ago
|
Type: defect → enhancement
Updated•2 years ago
|
Severity: -- → N/A
You need to log in
before you can comment on or make changes to this bug.
Description
•