Closed
Bug 1380599
Opened 7 years ago
Closed 7 years ago
Intermittent browser_bookmark_popup.js | Test timed out - | Found a tab after previous test timed out: about:home (browser_bookmark_popup.js can fail occasionally in ctrl_d_edit_bookmark_remove_bookmark)
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: intermittent-failure, regression)
Attachments
(1 file)
In one of my try runs for Async transactions, I noticed a few failures on Windows XP for:
INFO - Entering test bound ctrl_d_edit_bookmark_remove_bookmark
INFO - BookmarkingUI.status is 1
INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | Page should only be starred prior to popupshown if editing bookmark - true == true -
INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | Panel should be 'closed' to start test - "closed" == "closed" -
INFO - Buffered messages finished
INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Test timed out -
In bug 1376925 I changed a .click to a doCommand in the test before it, and forgot to revert it. So I suspect this is focus issues.
It seems simplest just to change it back to what it was.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: intermittent-failure
Summary: browser_bookmark_popup.js can fail occasionally in ctrl_d_edit_bookmark_remove_bookmark → Intermittent browser_bookmark_popup.js | Test timed out - | Found a tab after previous test timed out: about:home (browser_bookmark_popup.js can fail occasionally in ctrl_d_edit_bookmark_remove_bookmark)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8886103 [details]
Bug 1380599 - Revert accidental change to from .click to doCommand in browser_bookmark_popup.js.
https://reviewboard.mozilla.org/r/156898/#review162040
I actually wondered about this change during the review, but I just assumed it was due to some obscure reasons to make the test happy :)
Attachment #8886103 -
Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62987053a394
Revert accidental change to from .click to doCommand in browser_bookmark_popup.js. r=mak
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
status-firefox54:
--- → unaffected
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•