Open
Bug 1381004
Opened 7 years ago
Updated 2 years ago
Draw the titlebar as part of the Firefox content instead of using the Windows native titlebar
Categories
(Firefox :: Theme, defect, P5)
Firefox
Theme
Tracking
()
NEW
People
(Reporter: johannh, Unassigned)
References
Details
+++ This bug was initially created as a clone of Bug #1379268 +++
Quoting mstange from bug 1379268 comment 5:
> The other option would be to draw the titlebar as part of the Firefox content
> instead of using the Windows native titlebar. Then the whole window would switch
> delayed, but at least it would switch at the same time.
Shorlander and I agreed on IRC that this sounds like the better solution to the problem that was short-term solved in bug 1379268.
Markus, do you know what is required to enable this?
Flags: needinfo?(mstange)
Reporter | ||
Comment 1•7 years ago
|
||
Ah, wrong title and component, I guess.
Component: Theme → Widget: Win32
Priority: P1 → --
Product: Firefox → Core
Summary: Switching between Firefox windows caused tab background color to lag behind titlebar → Draw the titlebar as part of the Firefox content instead of using the Windows native titlebar
Comment 2•7 years ago
|
||
There would be no widget work needed for this, afaik, only front-end.
However this is still too much work and implied risk for too little reward, considering that it only affects users enabling the title bar. It's not even clear that bug 1379268's short-term solution is bad from a user's perspective; users enabling the native title bar may not want the accent color to extend behind the menu bar and tabs, since that's an unusually big area to apply the accent color to. See bug 1378855.
I think this is out of scope for photon, and borderline wontfix.
Iteration: 56.3 - Jul 24 → ---
Component: Widget: Win32 → Theme
Product: Core → Firefox
Whiteboard: [photon-visual][triage]
Please note that whether the accent color appears on the title bar is a user configurable setting on Windows 10.
Comment 4•7 years ago
|
||
In case of Lightweight theme is applied, I think that the title bar color should be kept the accent color、and Lightweight theme should only be applied to tabbar, menubar and bookmarks toolbar.
Comment 5•7 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #0)
> Markus, do you know what is required to enable this?
I agree with what Dão said. This would be entirely frontend work: Putting the title string inside a <xul:label> and moving it in the right place, having the window button placeholders in the right place, etc.
Flags: needinfo?(mstange)
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Priority: P3 → P4
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Priority: P4 → P5
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•