Firefox title bar should pick up the Windows 10 accent color when in the foreground
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox56 | --- | verified |
People
(Reporter: verdi, Assigned: dao)
References
(Depends on 3 open bugs, Blocks 2 open bugs)
Details
(Whiteboard: [photon-visual][p2][parity-Chrome][parity-IE][parity-Opera])
Attachments
(13 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/x-review-board-request
|
johannh
:
review+
|
Details |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details |
Reporter | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Reporter | ||
Comment 3•9 years ago
|
||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
Comment 8•9 years ago
|
||
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
Comment 14•9 years ago
|
||
Comment 15•9 years ago
|
||
Comment 17•9 years ago
|
||
Comment 19•9 years ago
|
||
Comment 20•9 years ago
|
||
Comment 21•9 years ago
|
||
Comment 22•9 years ago
|
||
Comment 24•9 years ago
|
||
Comment 25•9 years ago
|
||
Comment 26•9 years ago
|
||
Comment 27•9 years ago
|
||
Comment 28•9 years ago
|
||
Comment 29•9 years ago
|
||
Comment 30•9 years ago
|
||
Comment 31•9 years ago
|
||
Comment 32•9 years ago
|
||
Updated•9 years ago
|
Updated•9 years ago
|
Updated•9 years ago
|
Comment 34•8 years ago
|
||
Comment 35•8 years ago
|
||
Comment 36•8 years ago
|
||
Comment 37•8 years ago
|
||
Comment 38•8 years ago
|
||
Comment 39•8 years ago
|
||
Comment 40•8 years ago
|
||
Comment hidden (off-topic) |
Comment 42•8 years ago
|
||
Comment 43•8 years ago
|
||
Comment 44•8 years ago
|
||
Comment 45•8 years ago
|
||
Comment 46•8 years ago
|
||
Comment 47•8 years ago
|
||
Comment 48•8 years ago
|
||
Comment 49•8 years ago
|
||
Comment 50•8 years ago
|
||
Comment 51•8 years ago
|
||
Comment 52•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Comment 53•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Comment 54•7 years ago
|
||
Comment 55•7 years ago
|
||
Comment 56•7 years ago
|
||
Comment 57•7 years ago
|
||
Comment 58•7 years ago
|
||
Comment 59•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment 61•7 years ago
|
||
mozreview-review |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 64•7 years ago
|
||
mozreview-review |
Comment 65•7 years ago
|
||
Comment 66•7 years ago
|
||
bugherder |
Comment 67•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Comment 68•7 years ago
|
||
Comment 69•7 years ago
|
||
Comment 70•7 years ago
|
||
Comment 71•7 years ago
|
||
Comment 72•7 years ago
|
||
Comment 73•7 years ago
|
||
Comment 74•3 years ago
|
||
oofie this just became relevant again unless im missing something :((((
Comment 75•3 years ago
|
||
To me it seems broken as well. For reference, I've attached a screenshot: on the left is an app that takes Windows' system title bar color (as per user setting), and on the right is Firefox in "System Theme", which is described to follow the system theme but does not have the system title bar color. It currently seems to be the same color as seen in the "Light Theme".
Given its description of "Follows the operating system for (...) windows", I would expect the Firefox System Theme title bar to match that of the unthemed app.
Comment 76•3 years ago
|
||
(In reply to eweitenberg from comment #75)
Given its description of "Follows the operating system for (...) windows", I would expect the Firefox System Theme title bar to match that of the unthemed app.
Design differences aside (which is what I think Proton's change is, ultimately), I very much suspect the "system" theme is just an alias for "automatic" (meaning light/dark depending on system app mode). This in contrast to specific light/dark modes for example which would effectively force those modes instead of whatever the OS is trying to use.
Comment 77•3 years ago
|
||
I believe some of you might be interested in a userChrome based solution. Unfortunately you have to hardcode your accent color, since the -moz-win-accentcolor value does not seem to be supported any more.
@-moz-document url(chrome://browser/content/browser.xhtml) {
#TabsToolbar {
background: #ffb900;
}
#TabsToolbar:-moz-window-inactive {
background: inherit;
}
}
Comment 78•3 years ago
|
||
This isn't fixed. While FF91 did honor the Windows color selection, FF92 again ignores it.
Comment 79•3 years ago
|
||
(In reply to TomK from comment #78)
This isn't fixed. While FF91 did honor the Windows color selection, FF92 again ignores it.
@Dao, did we change anything here intentionally for Firefox 92?
Comment 80•3 years ago
|
||
Firefox 92 removed non-Proton code path for the title bar color. I guess bug 1722586.
Assignee | ||
Comment 81•3 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #79)
(In reply to TomK from comment #78)
This isn't fixed. While FF91 did honor the Windows color selection, FF92 again ignores it.
@Dao, did we change anything here intentionally for Firefox 92?
Not that I know, other than proton changes that I wasn't directly involved with. Proton did break this on purpose, did it not? I personally think that was a step backwards but again I wasn't involved with that.
Comment 82•3 years ago
|
||
Yes, Proton changed the expectation here but that was in Firefox 89, so it was surprising to see comment 78. @TomK, did you have Proton disabled via prefs?
Comment 83•3 years ago
|
||
Proton is enabled.
See the attached screenshots
firefox-92.png shows Firefox after the upgrade (and the proton settings) and notepad-titlebar.png with notepad.exe showing the configured title bar color.
Putting the following into userChrome.css fixes this (again)
.titlebar-color {
color: -moz-accent-color-foreground;
background-color: -moz-accent-color;
}
Why do I have to mess around with userChrome after every upgrade to get a sensible UI back?
Comment 84•3 years ago
|
||
Comment 85•3 years ago
|
||
Updated•3 years ago
|
Description
•