Consider caching getComputedStyle styles in display: none subtrees.
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Tracking
()
People
(Reporter: mconley, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Keywords: perf, Whiteboard: [Stylo])
Attachments
(3 files)
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Reporter | ||
Comment 6•7 years ago
|
||
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Assignee | ||
Comment 9•7 years ago
|
||
Assignee | ||
Comment 10•7 years ago
|
||
Updated•7 years ago
|
Comment 11•7 years ago
|
||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Assignee | ||
Comment 15•7 years ago
|
||
Updated•7 years ago
|
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Comment 18•7 years ago
|
||
Assignee | ||
Comment 19•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Comment 20•7 years ago
|
||
Updated•7 years ago
|
Comment 22•7 years ago
|
||
Updated•7 years ago
|
Comment 23•7 years ago
|
||
Comment 24•7 years ago
|
||
Updated•7 years ago
|
Assignee | ||
Comment 25•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Comment 26•7 years ago
|
||
Comment 27•6 years ago
|
||
Assignee | ||
Comment 28•6 years ago
|
||
Comment 29•6 years ago
|
||
Assignee | ||
Comment 30•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 31•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 32•6 years ago
|
||
See bug 1547409. Migrating webcompat priority whiteboard tags to project flags.
Updated•3 years ago
|
Comment 34•3 years ago
|
||
The webcompat issue linked in that bug is not reproducing anymore. It's just a perf issue (maybe) for some unknown sites.
Updated•3 years ago
|
Assignee | ||
Comment 36•2 years ago
|
||
This reuses our existing undisplayed style generation, but in a
per-document rather than per-nsComputedDOMStyle object, which means that
we can avoid re-resolving styles of elements in display: none subtrees
much more often.
This brings the test-case in the bug to par with other browsers or
better, and is much simpler than the initial approach I tried back in
the day.
Assignee | ||
Updated•2 years ago
|
Comment 37•2 years ago
|
||
Nice :-)
Assignee | ||
Comment 38•2 years ago
|
||
I had to fix a couple pre-existing under-invalidation issues, but should be green now:
https://treeherder.mozilla.org/jobs?repo=try&revision=0850057c9752cad29bbff59dbcf74cfbbad3899e
Comment 39•2 years ago
|
||
Comment 40•2 years ago
|
||
bugherder |
Description
•