Closed
Bug 1771564
Opened 2 years ago
Closed 2 years ago
Some drive-by nsComputedDOMStyle cleanup and optimization.
Categories
(Core :: CSS Parsing and Computation, task)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
Bug 1771564 - Don't re-resolve styles of elements without frames (but with styles). r=dholbert,boris
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•2 years ago
|
||
None of the consumer need to mutate styles, and this saves some ugly
const_casting on the next patch.
Doesn't change behavior.
|
|
Assignee | |
Comment 2•2 years ago
|
||
I noticed this while debugging some underinvalidation with the patch on
bug 1381071.
This doesn't change behavior effectively, since the style frame should
always have the element's style, but it allows us to not need style
resolution for:
- display: contents
- Any element before we flush layout for the first time.
So it seems worth it.
Depends on D147555
|
||
Updated•2 years ago
|
Attachment #9278568 -
Attachment is obsolete: true
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0618183b0fbe
Constify ComputedStyle usage in nsComputedDOMStyle. r=dholbert
|
|
Assignee | |
Updated•2 years ago
|
Summary: Some drive-by nsComputedDOMStyle cleanup and optimization.\ → Some drive-by nsComputedDOMStyle cleanup and optimization.
|
|
||
Updated•2 years ago
|
Attachment #9278568 -
Attachment is obsolete: false
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/bc528e3ae14e
Fix macOS builds.
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0618183b0fbe
https://hg.mozilla.org/mozilla-central/rev/bc528e3ae14e
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fe2a93fd2c0
Don't re-resolve styles of elements without frames (but with styles). r=dholbert
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•