Closed
Bug 1384724
Opened 7 years ago
Closed 7 years ago
Stylo: Windows reftest runs frequently crash at suite start
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
Details
(Keywords: crash)
Attachments
(1 file)
Many (but not all) Windows reftest runs are crashing during suite start:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6813000f2a777de4ed8d410522ef9dc4bf8f6de5&filter-searchStr=stylo%20windows%20tc-R
It seems more prevalent for stylo vs. gecko runs.
An example log:
https://treeherder.mozilla.org/logviewer.html#?job_id=117750949&repo=try&lineNumber=1742
Nothing in the log seemed like an obvious cause to me.
Assignee | ||
Comment 1•7 years ago
|
||
I'll try to reproduce on a Windows loaner.
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> I'll try to reproduce on a Windows loaner.
Currently this is failing because the loaner dies in ~5 minutes each time. Working on it with TC team in bug 1384752.
Comment 3•7 years ago
|
||
Assigning to jryans because it looks like he is working on it. :)
Assignee | ||
Comment 4•7 years ago
|
||
Updated•7 years ago
|
Priority: P1 → --
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
After :bholley's hint in today's meeting, I discovered that the special Stylo tests don't use the same virtualization setting as the main tests there were copied from. Setting that appears to fix this issue.
No longer depends on: 1384752
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8892633 [details]
Bug 1384724 - Use matching virtualization for Stylo tests.
https://reviewboard.mozilla.org/r/163620/#review169228
::: taskcluster/ci/test/tests.yml:669
(Diff revision 1)
> mochitest-chrome-style:
> description: "Mochitest chrome run for style system"
> suite: mochitest/chrome-style
> treeherder-symbol: tc-M(cs)
> loopback-video: true
> + virtualization: hardware
I don't see mochitest-chrome in your try push. Did you see this working elsewhere?
You may need to specify the worker type to buildbot-bridge as in mochitest-chrome.
Attachment #8892633 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8892633 [details]
Bug 1384724 - Use matching virtualization for Stylo tests.
https://reviewboard.mozilla.org/r/163620/#review169228
> I don't see mochitest-chrome in your try push. Did you see this working elsewhere?
>
> You may need to specify the worker type to buildbot-bridge as in mochitest-chrome.
Ah, good call. A try run[1] that includes them has those jobs stuck pending, so perhaps this is to blame.
I'll try to roll back to regular virtualization or virtual with GPU for this job first.
[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a31ea51c6ac70267fb3abfe427ad5085501ec9a0&filter-searchStr=M(cs)
Assignee | ||
Comment 9•7 years ago
|
||
mochitest-chrome-style using virtual:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=03fe4e55d8e202c5d7cdee9e2c9ad426bca43fb5
mochitest-chrome-style using virtual-with-gpu:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a8e876e213504d6e03bb488653166e21890eba2
Assignee | ||
Comment 10•7 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #9)
> mochitest-chrome-style using virtual:
>
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=03fe4e55d8e202c5d7cdee9e2c9ad426bca43fb5
>
> mochitest-chrome-style using virtual-with-gpu:
>
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=7a8e876e213504d6e03bb488653166e21890eba2
Looks like regular virtualization is enough for these jobs for now (I had only added "hardware" to make things more consistent).
Something to watch out for if we grow the mochitest-chrome-style task to run more directories, but for now I'll revert it to regular virtualization.
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2b56de144b83
Use matching virtualization for Stylo tests. r=catlee
Comment 13•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 14•7 years ago
|
||
We aren't running Stylo tests on Windows (bug 1385027) in Beta 56, so we don't need to uplift this test fix to Beta 56.
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
Comment 15•7 years ago
|
||
https://hg.mozilla.org/projects/date/rev/2b56de144b83884068364c4569e249c375fcd67b
Bug 1384724 - Use matching virtualization for Stylo tests. r=catlee
You need to log in
before you can comment on or make changes to this bug.
Description
•