Closed
Bug 1385027
Opened 7 years ago
Closed 7 years ago
Enable Stylo tests on Win32 and Win64
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
Details
(Whiteboard: [Stylo])
Attachments
(3 files)
Enable the stylo-tests set in parallel only for Win32 and Win64.
Updated•7 years ago
|
Updated•7 years ago
|
Priority: -- → P1
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Updated•7 years ago
|
Summary: Stylo: Enable Stylo tests on Win32 and Win64 → Enable Stylo tests on Win32 and Win64
Assignee | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
When you are ready, you should be able to activate the AWSY stylo tests on Windows as well:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa83b1463e2b061ed6ca9a92faf61776f1376df7#l1.42
Comment 3•7 years ago
|
||
Before enabling these tests, we are going to have to ensure that we don't run into the same load problems that enabling them on macosx created (see bug 1386625)
Also, in the stylo meeting we decided that we could disable the tests on inbound, would this be appropriate for windows platforms as well?
In addition, we will have to ensure that we enable SETA for these tests before they are enabled.
bc: side note, I am writing a patch for your AWSY tests so the mac ones aren't enabled on all trunk branches by default to contribute to the load we are seeing in bug 1386625
Comment 4•7 years ago
|
||
thank you.
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Kim Moir [:kmoir] ET from comment #3)
> Also, in the stylo meeting we decided that we could disable the tests on
> inbound, would this be appropriate for windows platforms as well?
Yes, I'll update the run-on-platforms to exclude inbound here as well.
> In addition, we will have to ensure that we enable SETA for these tests
> before they are enabled.
What's required to do this?
Flags: needinfo?(kmoir)
Assignee | ||
Comment 6•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8893062 [details]
Bug 1385027 - Update Stylo test annotations for Windows.
https://reviewboard.mozilla.org/r/164046/#review169410
Attachment #8893062 -
Flags: review?(manishearth) → review+
Comment 11•7 years ago
|
||
I added a dependency on bug 1386806, this is the needinfo for comment 5
Flags: needinfo?(kmoir)
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8893063 [details]
Bug 1385027 - Normalize run-on-projects for Stylo jobs.
https://reviewboard.mozilla.org/r/164048/#review169876
::: taskcluster/ci/test/tests.yml:1150
(Diff revision 1)
> by-test-platform:
> # Deactivate try on Buildbot, by default. We don't have enough machines
> windows8-64.*: ['mozilla-release', 'mozilla-beta', 'mozilla-central', 'mozilla-inbound', 'autoland']
> windows8-64-devedition/opt: built-projects # No dev edition outside of supported branches
> windows10.*: []
> - macosx64-stylo/.*: ['autoland', 'mozilla-central', 'try']
> + linux64-stylo.*: ['autoland', 'mozilla-central', 'try']
Couldn't these three lines be
.*-stylo.*: ['autoland', 'mozilla-central', 'try']
instead of each platform separately
same thing on line 123
Assignee | ||
Comment 13•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8893063 [details]
Bug 1385027 - Normalize run-on-projects for Stylo jobs.
https://reviewboard.mozilla.org/r/164048/#review169876
> Couldn't these three lines be
>
> .*-stylo.*: ['autoland', 'mozilla-central', 'try']
>
> instead of each platform separately
>
> same thing on line 123
Actually, that's what I wanted to do, and I started with that! :) But there's a step that throws an error if more than one of the lines matches here. Since we are adding some jobs that start with `windows10.*`, there would then be two possible lines to match a test platform like `windows10-64-stylo/opt`.
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8893064 [details]
Bug 1385027 - Enable Stylo tests on Windows.
https://reviewboard.mozilla.org/r/164050/#review169892
Attachment #8893064 -
Flags: review?(kmoir) → review+
Assignee | ||
Updated•7 years ago
|
Whiteboard: [Stylo]
Assignee | ||
Comment 15•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8893063 [details]
Bug 1385027 - Normalize run-on-projects for Stylo jobs.
https://reviewboard.mozilla.org/r/164048/#review169914
Attachment #8893063 -
Flags: review?(kmoir) → review+
Assignee | ||
Comment 18•7 years ago
|
||
This is ready to land once we work out the SETA thing in bug 1386806.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 25•7 years ago
|
||
Assignee | ||
Comment 26•7 years ago
|
||
SETA is ready, so I'll land this assuming the new try run looks good.
Comment hidden (mozreview-request) |
Comment 28•7 years ago
|
||
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/105f02180214
Update Stylo test annotations for Windows. r=manishearth
https://hg.mozilla.org/integration/autoland/rev/f845d496a1dc
Normalize run-on-projects for Stylo jobs. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/4d6a54bb44d4
Enable Stylo tests on Windows. r=kmoir
Comment 29•7 years ago
|
||
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d72cefffd1c2
Remove duplicate run-on-project for AWSY. r=me DONTBUILD
Comment 30•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/105f02180214
https://hg.mozilla.org/mozilla-central/rev/f845d496a1dc
https://hg.mozilla.org/mozilla-central/rev/4d6a54bb44d4
https://hg.mozilla.org/mozilla-central/rev/d72cefffd1c2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•