Open Bug 1385444 Opened 7 years ago Updated 2 years ago

Remove support for "skin" chrome registration after removing support for complete themes

Categories

(Toolkit :: Add-ons Manager, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: MattN, Unassigned)

References

(Blocks 1 open bug, )

Details

Once we no longer support complete themes replacing "skin" packages, we can simply our chrome registration and architecture by removing support for "skin" and moving everything to "content". This is option (A) in the email to firefox-dev[1] which bsmedberg supported. My only concern is whether there potential to introduce security issues since the "content" package is chrome privileged.

We probably need dependency bugs to merge/move existing skin contents.

[1] https://developer.mozilla.org/en-US/docs/Chrome_Registration#skin
(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #0)
> Once we no longer support complete themes replacing "skin" packages, we can
> simply our chrome registration and architecture by removing support for
> "skin" and moving everything to "content".

And while we're at it, maybe we get rid of content/? Is there a reason to prefer chrome://browser/content/browser.js over chrome://browser/browser.js?
(In reply to Dão Gottwald [::dao] from comment #1)
> (In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking
> you) from comment #0)
> > Once we no longer support complete themes replacing "skin" packages, we can
> > simply our chrome registration and architecture by removing support for
> > "skin" and moving everything to "content".
> 
> And while we're at it, maybe we get rid of content/? Is there a reason to
> prefer chrome://browser/content/browser.js over chrome://browser/browser.js?

We probably need to keep that until the locale parts go away.
Priority: -- → P3

What is the status of this bug?

At Thunderbird we are unsure how to proceed with skin resources. Can we still use skin resources and even move resources from content to skin, or should we slowly stop using skin resources altogether?

Is there an estimate when skin resources will be unsupported?

(In reply to John Bieling (:TbSync) from comment #3)

What is the status of this bug?

At Thunderbird we are unsure how to proceed with skin resources. Can we still use skin resources and even move resources from content to skin, or should we slowly stop using skin resources altogether?

Is there an estimate when skin resources will be unsupported?

NI to Mossop.

Flags: needinfo?(dtownsend)

Not knowing about this bug we had canonized the little remaining content css to skin (bug 1707211) but now found some fallout from that in how add-ons and themes can access that css (bug 1733060). Input appreciated.

We're discussing maybe even moving away from the chrome protocol entirely but at the moment this is a low priority and I don't believe that anything is happening.

Flags: needinfo?(dtownsend)

Is there a bug for that?

No it is really a discussion at this point with no concrete plan in place

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.