Closed
Bug 1385518
Opened 7 years ago
Closed 6 years ago
[Photon] Update sidebar styling for dark theme
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 64
People
(Reporter: nhnt11, Assigned: ntim)
References
(Depends on 1 open bug)
Details
(Whiteboard: [reserve-photon-visual][p3][ntim-intern-project])
Attachments
(3 files)
Background should be dark.
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual] [triage]
Updated•7 years ago
|
Whiteboard: [photon-visual] [triage] → [reserve-photon-visual][p3]
Updated•7 years ago
|
Flags: qe-verify+
Updated•7 years ago
|
Priority: -- → P3
QA Contact: brindusa.tot
Updated•7 years ago
|
Priority: P3 → P4
Updated•7 years ago
|
Updated•7 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: P4 → P1
Updated•7 years ago
|
status-firefox56:
--- → wontfix
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Depends on: dark-theme-darkening
Updated•7 years ago
|
Blocks: dark-theme-darkening
No longer depends on: dark-theme-darkening
Updated•7 years ago
|
Assignee: jaws → nobody
Status: ASSIGNED → NEW
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8919591 [details]
Bug 1385518 - (WIP) Update sidebar styling for dark theme.
https://reviewboard.mozilla.org/r/190456/#review228422
::: browser/components/places/content/sidebarUtils.js:20
(Diff revision 2)
> + document.documentElement.style.setProperty("--chrome-secondary-background-color", background);
> + document.documentElement.style.setProperty("--chrome-color", color);
> + document.documentElement.setAttribute("compacttheme", "true");
Note that you're definitely not supposed to be dirtying the DOM inside a promiseLayoutFlushed callback.
Updated•7 years ago
|
Assignee: nobody → stokesdy
Assignee | ||
Updated•7 years ago
|
Assignee: stokesdy → nobody
Assignee | ||
Comment 9•7 years ago
|
||
This will be much easier to do with bug 1418602 fixed, leaving this bug on hold for now.
Assignee | ||
Updated•6 years ago
|
No longer blocks: dark-theme-darkening
Assignee | ||
Updated•6 years ago
|
Whiteboard: [reserve-photon-visual][p3] → [reserve-photon-visual][p3][ntim-intern-project]
Assignee | ||
Comment 11•6 years ago
|
||
Now that bug 1418602 is fixed, we can simply add the sidebar/sidebar_text properties to nsBrowserGlue.js.
Although, I'm thinking it's better to get bug 1484891 and bug 1485017 fixed first, to avoid shipping a half-baked dark sidebar.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ntim.bugs
Assignee | ||
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
Comment on attachment 9005869 [details]
Bug 1385518 - Update sidebar styling for dark theme. r=jaws
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9005869 -
Flags: review+
Comment 14•6 years ago
|
||
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af2c47f0c8d7
Update sidebar styling for dark theme. r=jaws
Comment 15•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 16•6 years ago
|
||
I have reproduced this bug with Nightly 56.0a1 (2017-07-28) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!
Build ID - 20180910220142
User Agent - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64
QA Whiteboard: [bugday-20180905]
Assignee | ||
Comment 17•6 years ago
|
||
Hi Amy, would it be possible to get a quick UI-review of the dark theme sidebar (bookmarks/history/synced tabs) during the 64 cycle ? This is already in Nightly.
Thank you.
Flags: needinfo?(amlee)
Comment 18•6 years ago
|
||
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #17)
> Hi Amy, would it be possible to get a quick UI-review of the dark theme
> sidebar (bookmarks/history/synced tabs) during the 64 cycle ? This is
> already in Nightly.
>
> Thank you.
Hi,
Took a quick look and there are some edits I'd like to make. Will post them once I make my notes
Flags: needinfo?(amlee)
Comment 19•6 years ago
|
||
Hi,
Please see below for the CSS for the dark them side bar. Thanks!
https://firefoxux.github.io/people/amlee/Dark-Theme-Sidebar
Assignee | ||
Comment 20•6 years ago
|
||
(In reply to Amy Lee [:amylee] UX from comment #19)
> Hi,
>
> Please see below for the CSS for the dark them side bar. Thanks!
>
> https://firefoxux.github.io/people/amlee/Dark-Theme-Sidebar
Thanks! I'll file bugs for individual items.
Comment 21•6 years ago
|
||
Build ID 20181001100147
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Verified this bug on latest Nightly 64.0a1 on Windows 10 x64 and Mac OS X 10.13 and the background color for the Dark theme is grey, not black. Please see the attachment. Is this the expected color for background on the sidebars?
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(amlee)
Comment 24•6 years ago
|
||
Verified on Ubuntu 16.04 with latest Nightly 64.01 (10.02.2018) and the bug is fixed, the background color for sidebars is dark grey when using the Dark theme.
You need to log in
before you can comment on or make changes to this bug.
Description
•