Closed
Bug 1485599
Opened 6 years ago
Closed 6 years ago
Color sidebar scrollbars according to sidebar properties
Categories
(Firefox :: Theme, enhancement, P5)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: ntim, Assigned: Paenglab)
References
Details
Attachments
(4 files, 2 obsolete files)
We can use the scrollbar-face-color and scrollbar-track-color properties to do this.
Updated•6 years ago
|
Priority: -- → P5
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
Reporter | ||
Comment 2•6 years ago
|
||
Note that this depends on bug 1501586
Assignee | ||
Comment 3•6 years ago
|
||
With this colours, the scrollbar up/down arrows are almost not visible with a light theme and with the dark theme not visible on Windows.
Reporter | ||
Updated•6 years ago
|
Assignee: ntim.bugs → nobody
Assignee | ||
Comment 4•6 years ago
|
||
Tim, what do you think about this? With this colours are the arrows visible.
I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);
Attachment #9020626 -
Flags: feedback?(ntim.bugs)
Reporter | ||
Comment 5•6 years ago
|
||
Comment on attachment 9020626 [details]
scrollbar-proposal.png
(In reply to Richard Marti (:Paenglab) from comment #4)
> Created attachment 9020626 [details]
> scrollbar-proposal.png
>
> Tim, what do you think about this? With this colours are the arrows visible.
>
> I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for
> [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);
Looks good to me! Can you post screenshots of MacOS and Linux as well ?
Amy, could you please look at this proposal ? Right now, the scrollbars are light regardless of the theme and we'd like to switch to alpha colors to make sure they blend in well for the dark theme too.
Attachment #9020626 -
Flags: feedback?(ntim.bugs)
Attachment #9020626 -
Flags: feedback?(amlee)
Attachment #9020626 -
Flags: feedback+
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → richard.marti
Assignee | ||
Comment 6•6 years ago
|
||
Scrollbars on Ubuntu with the proposed scrollbar colours.
Assignee | ||
Comment 7•6 years ago
|
||
Scrollbars on Mac with the proposed scrollbar colours.
Reporter | ||
Updated•6 years ago
|
Attachment #9020601 -
Attachment is obsolete: true
Comment 8•6 years ago
|
||
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #5)
> Comment on attachment 9020626 [details]
> scrollbar-proposal.png
>
> (In reply to Richard Marti (:Paenglab) from comment #4)
> > Created attachment 9020626 [details]
> > scrollbar-proposal.png
> >
> > Tim, what do you think about this? With this colours are the arrows visible.
> >
> > I used for [lwt-sidebar] rgba(204,204,204,.5) rgba(230,230,235,.5); and for
> > [lwt-sidebar-brighttext] rgba(249,249,250,.4) rgba(20,20,25,.3);
>
> Looks good to me! Can you post screenshots of MacOS and Linux as well ?
>
> Amy, could you please look at this proposal ? Right now, the scrollbars are
> light regardless of the theme and we'd like to switch to alpha colors to
> make sure they blend in well for the dark theme too.
This looks good to me. Thanks
Assignee | ||
Comment 9•6 years ago
|
||
Tim, I have no phabricator configured. Does obsoleting the phabricator patch in bugzilla also obsolete the patch in phabricator? If not, please could you do it?
Attachment #9019597 -
Attachment is obsolete: true
Attachment #9020837 -
Flags: review?(dao+bmo)
Updated•6 years ago
|
Attachment #9020837 -
Flags: review?(dao+bmo) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 10•6 years ago
|
||
Keywords: checkin-needed
Reporter | ||
Updated•6 years ago
|
Attachment #9020626 -
Flags: feedback?(amlee)
Comment 11•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Updated•6 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•