Closed
Bug 1385880
Opened 7 years ago
Closed 7 years ago
Disable/Enable hides extension options
Categories
(WebExtensions :: Untriaged, defect, P5)
WebExtensions
Untriaged
Tracking
(firefox54 unaffected, firefox55 disabled, firefox56 wontfix, firefox57 verified)
VERIFIED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox54 | --- | unaffected |
firefox55 | --- | disabled |
firefox56 | --- | wontfix |
firefox57 | --- | verified |
People
(Reporter: marius.santa, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
[Affected versions]:
Firefox 56.0a1 (2017-07-30)
[Affected platforms]:
Windows 10 64-bit
Mac Os X 10.12.3
[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Make sure that "extensions.webextensions.remote” pref is set to true.
3.Install the following webextension: https://addons.mozilla.org/en-US/firefox/addon/adblock-for-youtube/ .
4.Press CTRL+SHIFT+A .
5.Click on extensions.
6.Double click on "AdBlocker for YouTube™".
7.Click on the "Disable" and then the "Enable" button.
[Expected Results]:
The webextension options are displayed..
[Actual Results]:
- The options are not displayed.
- See attached Gif.
Comment 1•7 years ago
|
||
Can we test this with "extensions.webextensions.remote” pref set to false?
Flags: needinfo?(marius.santa)
Reporter | ||
Comment 2•7 years ago
|
||
I retested it with "extensions.webextensions.remote” set to true/false and it only reproduces with the setting set to true.
Gif for the issue is attached.
Flags: needinfo?(marius.santa)
Reporter | ||
Comment 3•7 years ago
|
||
Changing title because issue is not specific to the mentioned extension.
Issue is also reproducible for other extensions with the same option type(ex. https://addons.mozilla.org/en-US/firefox/addon/tineye-reverse-image-search/?src=search)
Summary: "AdBlocker for YouTube™" options enable not working → Disable/Enable hides extension options
Comment 4•7 years ago
|
||
I'm not sure what's going on here, it looks like we're successfully creating a remote browser and then blowing up here:
http://searchfox.org/mozilla-central/rev/bbc1c59e460a27b20929b56489e2e55438de81fa/toolkit/content/browser-child.js#354
with
JavaScript error: chrome://global/content/browser-child.js, line 354: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIWebNavigation.loadURIWithOptions]
A wild shot-in-the-dark guess is that we try to load the options page before the extension has been set up so the moz-extension:// url isn't valid yet? Given enough time I could work through this but I have my hands full with other things right now, sending this over to Kris since it appears related to OOP.
Assignee: nobody → kmaglione+bmo
Updated•7 years ago
|
Priority: -- → P5
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8893974 [details]
Bug 1385880: Part 1 - Remove WebExtensionBootstrap.js.
https://reviewboard.mozilla.org/r/165046/#review170458
Attachment #8893974 -
Flags: review?(aswan) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8893975 [details]
Bug 1385880: Part 2 - Store promise returned by bootstrap startup method.
https://reviewboard.mozilla.org/r/165048/#review170460
Attachment #8893975 -
Flags: review?(aswan) → review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8893976 [details]
Bug 1385880: Part 3 - Wait for add-on startup before showing inline options browser.
https://reviewboard.mozilla.org/r/165050/#review170462
Attachment #8893976 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 13•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f8579ec94e8a2ff03e5299c13381b4234517a1
Bug 1385880: Part 1 - Remove WebExtensionBootstrap.js. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/618f5606f763e87fa64c2eee01f168fe1f34c6bb
Bug 1385880: Part 2 - Store promise returned by bootstrap startup method. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/8163646237aa5bc72f6414c9e73fcb4073d053eb
Bug 1385880: Part 3 - Wait for add-on startup before showing inline options browser. r=aswan
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f7f8579ec94e
https://hg.mozilla.org/mozilla-central/rev/618f5606f763
https://hg.mozilla.org/mozilla-central/rev/8163646237aa
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Reporter | ||
Comment 15•7 years ago
|
||
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 16•7 years ago
|
||
Tested on FF 57.0a1(2017-08-06/08) using Win 10(64Bit) and MacOS X(10.12.3).
Marking as Verified Fixed on FF 57.
Comment 17•7 years ago
|
||
Too late for 56. Mass won't fix for 56.
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•