Sören Hentzschel Reporter
	Description • 7 years ago

STR:

1. enable another theme in add-on mananger
2. switch back to default theme

expected:

The default theme is applied again.

actual result:

the default theme does not look like the default theme.

Please see the attached screencast.

	Johann Hofmann [:johannh]
	Comment 4 • 7 years ago

Can someone try finding the regression window with mozregression, please?

	Martin
	Comment 5 • 7 years ago

(In reply to Johann Hofmann [:johannh] from comment #4)
> Can someone try finding the regression window with mozregression, please?

Will look into it...
Have to say that the theme which is born from "Default > Dark > Default" doesn't look bad.

	Martin
	Comment 6 • 7 years ago

Here it is
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b48486fff5210dea14d87804ab57c6dc5353ee56&tochange=8585560b64f1e7a1ed5a7eb57c39a8701c25c2a9

	:Gijs (he/him)
	Comment 7 • 7 years ago

mozregression points to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4cfb674227051e22bab651e5759f3de503a50560&tochange=a9182f92641b24d0a972886aed27e784004a343f which makes me suspect bug 1342712. Tim?

	:Gijs (he/him)
	Comment 8 • 7 years ago

Confirmed that this broke in bug 1342712.

	Tim Nguyen :ntim Assignee
	Comment 9 • 7 years ago

The issue is pretty straightforward:

When switching back to the default theme, aData and parsedData are null. So the check for parsedData.window throws.

	:Gijs (he/him)
	Comment 11 • 7 years ago
mozreview-review

Comment on attachment 8894466 [details]
Bug 1387737 - Fix switching back to the default theme.

https://reviewboard.mozilla.org/r/165642/#review170722

	Pulsebot
	Comment 13 • 7 years ago

Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/864b3a48a8f8
Fix switching back to the default theme. r=Gijs

	Pulsebot
	Comment 14 • 7 years ago

Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/fde1450a4368
Fix switching back to the default theme. r=Gijs a=merge

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 15 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/fde1450a4368

	Carsten Book [:Tomcat]
	Comment 19 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/864b3a48a8f8

	Itiel
	Comment 21 • 7 years ago

Fixed on latest Nightly.

	Fahima Zulfath
	Comment 22 • 7 years ago

Managed to reproduce the issue on an affected build (Firefox 57.0a1), using the steps to reproduce from Comment 0, on Windows 10 X 64 bit. Hence the bug-1387737 is fixed & verified.
build ID: 20170809100326
[bugday-20170809]