Closed Bug 1388432 Opened 7 years ago Closed 7 years ago

RTL Photon download toolbar icon progressbar progresses incorrectly

Categories

(Firefox :: Downloads Panel, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.2 - Aug 29
Tracking Status
firefox57 --- fixed

People

(Reporter: itiel_yn8, Assigned: Paolo)

References

(Depends on 1 open bug)

Details

(Keywords: rtl, Whiteboard: [reserve-photon-animation])

Attachments

(2 files)

Attached image LTR vs. RTL progress bar (deleted) —
This is a follow-up to bug 1386800. After bug 1386800's patch has landed, the progressbar on the download icon now starts from the right and finishes at the left on RTL builds, but 2 issues arose that can be seen only during an (active?) download: 1. The right part of the progress bar has gotten a bit longer (and is not curvy anymore), compared to it's left side, and that's probably because of issue #2 2. The progressbar progresses with the curvy part instead of the part with the sharp end See attached (zoomed-in) screenshot for LTR progressbar (left) vs. RTL progressbar (right).
Whiteboard: [photon-animation] [triage]
Flags: needinfo?(sfoster)
> 1. The right part of the progress bar has gotten a bit longer (and is not > curvy anymore), compared to it's left side, and that's probably because of > issue #2 > 2. The progressbar progresses with the curvy part instead of the part with > the sharp end Thanks for spotting that - good eyes. I'll leave this open, but I hope to take care of this in bug 1387557 which touches the same code.
No longer blocks: 1386800
Depends on: 1387557
Flags: needinfo?(sfoster)
Flags: qe-verify?
Priority: -- → P4
Whiteboard: [photon-animation] [triage] → [reserve-photon-animation]
Flags: qe-verify? → qe-verify-
Taking this while bug 1387557 is in the works, since I'm also adjusting the progress bar limits for bug 1296554.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P4 → P1
Blocks: 1296554
Comment on attachment 8899465 [details] Bug 1388432 - Fix progress bar limits and RTL behavior in the Downloads Indicator. https://reviewboard.mozilla.org/r/170750/#review175908 rs=me
Attachment #8899465 - Flags: review?(jaws) → review+
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ea8bfe12e651 Fix progress bar limits and RTL behavior in the Downloads Indicator. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Iteration: --- → 57.2 - Aug 29
Unable to verify, the download button is gone, also from the customization panel. And, for some reason the downloads window (Ctrl+J) is now borderless (using Windows 10). No controls either (Close, Minimize, Maximize). Is this intended?
The bug itself is now fixed and the progressbar now progresses correctly also on RTL. (In reply to ItielMaN from comment #7) > Unable to verify, the download button is gone, also from the customization > panel. That's still an issue (unless intended). The download button appears only if there's an active ongoing download, or if there are item in the preview panel. (In reply to ItielMaN from comment #7) > And, for some reason the downloads window (Ctrl+J) is now borderless (using > Windows 10). No controls either (Close, Minimize, Maximize). And that one's already fixed by other reported bug.
Status: RESOLVED → VERIFIED
(In reply to ItielMaN from comment #8) > (In reply to ItielMaN from comment #7) > > Unable to verify, the download button is gone, also from the customization > > panel. > > That's still an issue (unless intended). The download button appears only if > there's an active ongoing download, or if there are item in the preview > panel. This is tracked in bug 1371765.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: