Closed
Bug 1390048
Opened 7 years ago
Closed 7 years ago
UITour fails to open the pocket panel
Categories
(Firefox :: Tours, defect)
Firefox
Tours
Tracking
()
RESOLVED
DUPLICATE
of bug 1385418
People
(Reporter: Fischer, Unassigned)
References
Details
STR:
1. Enter https://support.mozilla.org/en-US/
2. Open Web Console
3. In the console, run `Mozilla.UITour.showMenu("pocket");`
Expected:
The pocket panel shows
Actual:
The pocket panel doesn't show but an error of "UITour:Can't open the pocket menu without a view" in the Browser Toolbox console shows.
Reporter | ||
Comment 1•7 years ago
|
||
(In reply to Fischer [:Fischer] from comment #0)
> STR:
> 1. Enter https://support.mozilla.org/en-US/
> 2. Open Web Console
> 3. In the console, run `Mozilla.UITour.showMenu("pocket");`
>
> Expected:
> The pocket panel shows
>
> Actual:
> The pocket panel doesn't show but an error of "UITour:Can't open the pocket
> menu without a view" in the Browser Toolbox console shows.
Pocket was moved into the Page Action and became obsolete in the CustomizableUI[1] so UITour needs to update its way to open the Pocket panel as well.
As the bug 1388528 comment 8, we are going to do some updates on how to anchor the Pocket panel in the bug 1385418.
Probably we could visit this bug after the bug 1385418 gets the related logic finalized.
[1] http://searchfox.org/mozilla-central/rev/6482c8a5fa5c7446e82ef187d1a1faff49e3379e/browser/components/customizableui/CustomizableUI.jsm#68
Depends on: 1385418
Comment 2•7 years ago
|
||
Very similar to bug 1387697...
Comment 3•7 years ago
|
||
Like Gijs says, this is just bug 1387697, right? I'll dupe it there to avoid confusion. Apologies if I'm wrong.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Comment 4•7 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #3)
> Like Gijs says, this is just bug 1387697, right? I'll dupe it there to
> avoid confusion. Apologies if I'm wrong.
I think there might be separate code to actually open the panel for pocket, which is different from just highlighting the button. Fischer? Do we actually need this for the onboarding tours we intend to ship for 57?
Depends on: 1385418
Flags: needinfo?(fliu)
Comment 5•7 years ago
|
||
OK. I'm fixing that part too as part of bug 1385418. It's pretty simple.
Comment 6•7 years ago
|
||
(But if we want to track that separately, apologies for closing this bug.)
Reporter | ||
Comment 7•7 years ago
|
||
(In reply to :Gijs from comment #4)
> (In reply to Drew Willcoxon :adw from comment #3)
> > Like Gijs says, this is just bug 1387697, right? I'll dupe it there to
> > avoid confusion. Apologies if I'm wrong.
>
> I think there might be separate code to actually open the panel for pocket,
> which is different from just highlighting the button. Fischer? Do we
> actually need this for the onboarding tours we intend to ship for 57?
No the onboarding tours don't need this so no tight schedule for this bug. Sorry I should have put this clear on the description as well.
(In reply to Drew Willcoxon :adw from comment #6)
> (But if we want to track that separately, apologies for closing this bug.)
Hi Drew,
Thanks for addressing this bug btw. It is perfectly ok to duplicate this bug .
p.s Guess you wanted to set as a duplicate of bug 1385418 (per bug 1385418 comment 6 and the wip patch).
Flags: needinfo?(fliu)
You need to log in
before you can comment on or make changes to this bug.
Description
•