When WebRender is enabled, some shader creations happened on 2nd rendering. Each shader creation took 50ms - 150ms, then 2nd webrender rendering took about 600ms - 1000ms. The duration of 2nd composition was depended on PC.

I used the patch to quickly measure shaders creation time.

Measured shaders creation time with attachment 8898127 [details] [diff] [review]. It was measured on Lenovo P50(windows). Each shader creation took 43 ms - 151 ms and 2nd webrender rendering took 841ms.

The following is an advice by Jeff Gilbert via E-mail. ------------------------------------------------------------------------- My instinct here is that WR should keep a global shader cache itself. We do want a shader cache system for WebGL as well, so if we can kill two birds with one stone here, that would be a plus. I don't think we should try to embed shader caching in GLContext transparently. Straw-man: class ShaderProgramCache { map<Hasher::HashT, RefPtr<ProgramBinary>> cache; struct ProgramBinary : public RefCounted<ProgramBinary> { GLenum format; UniqueBuffer bytes; uint32_t byteLen; }; void Link(GLContext* gl, GLuint progId, const char* vertSource, const char* fragSource) { Hasher hasher; hasher.digest(gl->mRendererString); hasher.digest(vertSource); hasher.digest(fragSource); const auto hash = hasher.get(); const auto itr = cache.find(hash); if (itr != cache.end()) { const auto& bin = itr->second; gl->fProgramBinary(progId, bin->format, bin->bytes, bin->byteLen); return; } gl->fLinkProgram(progId); GLenum status = 0; gl->fGetProgramiv(progId, LOCAL_GL_LINK_STATUS, (GLint*)&status); if (!status) return; RefPtr<ProgramBinary> bin = new ProgramBinary; gl->fGetProgramiv(progId, LOCAL_GL_PROGRAM_BINARY_LENGTH, (GLint*)&bin->byteLen); bin->bytes = malloc(bin->byteLen); if (!bin->bytes) return; gl->fGetProgramBinary(progId, bin->byteLen, nullptr, &bin->format, bin->bytes.get()); cache.insert({hash, bin}); } }; Optional requirements: - Async linking - Serialize to/from blob/disk

I am going to take a look.

Rebased.

Without glProgramBinary usage, each shader compiling took 60ms - 500ms with ANGLE on P90(Win10). With glProgramBinary usage, each shader load became 4ms - 10ms with ANGLE on P90(Win10).

(In reply to Sotaro Ikeda [:sotaro] from comment #3) > The following is an advice by Jeff Gilbert via E-mail. > > ------------------------------------------------------------------------- > > I don't think we should try to embed shader caching in GLContext > transparently. > > Optional requirements: > - Async linking > - Serialize to/from blob/disk :jgilbert, can you explain more about "Async linking"? Thanks!

(In reply to Sotaro Ikeda [:sotaro] from comment #3) > > Optional requirements: > - Async linking > - Serialize to/from blob/disk Optional requirements is going to be handled in different bugs.

(In reply to Sotaro Ikeda [:sotaro] from comment #14) > (In reply to Sotaro Ikeda [:sotaro] from comment #3) > > > > - Serialize to/from blob/disk Bug 1418202 is created for it.

For now, ProgramBinary is necessary for windows. On my linux PC, I did not see performance improvement.

Comment on attachment 8929359 [details] [diff] [review] patch - handle WebRender ProgramBinary usage :nical, can you feedback to the patch?

Comment on attachment 8929359 [details] [diff] [review] patch - handle WebRender ProgramBinary usage Review of attachment 8929359 [details] [diff] [review]: ----------------------------------------------------------------- Looks sane.

Comment on attachment 8931570 [details] [diff] [review] patch - Handle WebRender ProgramBinary usage Review of attachment 8931570 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!

Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e60ad275b73 Handle WebRender ProgramBinary usage r=nical

(In reply to Sotaro Ikeda [:sotaro] from comment #10) > (In reply to Sotaro Ikeda [:sotaro] from comment #3) > > The following is an advice by Jeff Gilbert via E-mail. > > > > ------------------------------------------------------------------------- > > > > I don't think we should try to embed shader caching in GLContext > > transparently. > > > > Optional requirements: > > - Async linking > > - Serialize to/from blob/disk > > :jgilbert, can you explain more about "Async linking"? Thanks! Async linking is where we call LinkProgram for all programs before querying the LINK_STATUS for any of them. This lets the driver do linking in parallel. I believe ANGLE supports this, or something similar.