Closed
Bug 1419440
Opened 7 years ago
Closed 7 years ago
Update webrender to b7b07562fda338fcb2faff66ce01aafb6235fbcf
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
(Blocks 1 open bug)
Details
(Whiteboard: [wr-mvp] [gfx-noted])
Attachments
(3 files)
+++ This bug was initially created as a clone of Bug #1418315 +++
I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.
When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".
[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Assignee | ||
Comment 1•7 years ago
|
||
Continuing from https://bugzilla.mozilla.org/show_bug.cgi?id=1418315#c9, :kvark provided a patch on servo/webrender#2075 that fixed the crash for me locally. Here is a try push that includes that patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b0a609eb6d1af3885d2dba56fc8a86d53f45b00
Assignee | ||
Comment 2•7 years ago
|
||
WR @ f5cb619ea6de27f89a0ce2e81001579ca36fcc18 (with kvark's fix)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6908fa67200d1871918edbcf864a2b5433d4a112
https://treeherder.mozilla.org/#/jobs?repo=try&revision=39c0f736a87e67ea08e4c11d21c49ae5169c4d46
Green. There was a windows crash but it's VR-related and nothing to do with webrender it seems.
WR @ 5019eb12c3e36053e02c0fdc4121604b4a0fdd3d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=07fa7851f28dfa1c26286f9a4e9f2a63e70aebb8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=813c6e0a0ed8ddcdba272eb2254022f3fe963e3f
Green
WR @ 02d9b6d939b92ab8f1cc5bdf6d69bc4b4fccf554
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a0044d4b0663b686e3193328bc35dc9174d74e1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3756a645b554e8a52d94958a801b2518084dd6f8
Debug build failures. For some reason cbindgen decided to remove the != operator on ImageKey, not really sure why. I'll look into it.
Assignee | ||
Comment 3•7 years ago
|
||
Debug build failures were due to bug 1418374. I fixed it with https://hg.mozilla.org/integration/mozilla-inbound/rev/0b60a5360f79
Assignee | ||
Comment 4•7 years ago
|
||
WR @ 02d9b6d939b92ab8f1cc5bdf6d69bc4b4fccf554, with the above fix
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf4065d0504d946ce6fc36712b485cd032ffdca5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cad491eb2b5b90c44531d80930a842fdc29fca6
Green
Assignee | ||
Comment 5•7 years ago
|
||
WR @ 2f810c89f8468ba04ae35b588944789fc14de5d5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa4b34380888c45d1f09b3a0bbe33d515fe6c32f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e685c5c0e84f7b74d7b277abaaf03410d4c2dec
Green
Assignee | ||
Comment 6•7 years ago
|
||
WR @ 5d82738ec66bc3868749ccc2859ef5a25214f497
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b83cd9e2c31ef8fa96e37019a5a3b3fdc972da8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3970de64c3e561b586e0754055992266ab96a235
Green
WR @ b7b07562fda338fcb2faff66ce01aafb6235fbcf
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e74082173c0ddf701451838afb402f9db40b087a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d81bd6c86e7e4f3a0f65d745d4799caece7023ab
Green
Assignee | ||
Comment 7•7 years ago
|
||
Enough stuff has landed in WR the last few days that I'd like do an update now.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to b7b07562fda338fcb2faff66ce01aafb6235fbcf
Version: unspecified → 59 Branch
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•7 years ago
|
||
Dzmitry, can you confirm that the the code I put in the second patch (the gecko-side changes needed to go with your document stuff) is correct? I put you as the author on the patch since I basically pulled the code from one of your try pushes.
Flags: needinfo?(kvark)
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee | ||
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8931371 [details]
Bug 1419440 - Update for API changes in WR PR 2050.
https://reviewboard.mozilla.org/r/202508/#review207866
Attachment #8931371 -
Flags: review?(bugmail) → review+
Assignee | ||
Comment 14•7 years ago
|
||
I agree! Thanks for writing it and testing on gecko, btw :)
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8931370 [details]
Bug 1419440 - Update webrender to commit b7b07562fda338fcb2faff66ce01aafb6235fbcf.
https://reviewboard.mozilla.org/r/202506/#review207874
Attachment #8931370 -
Flags: review?(mstange) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8931372 [details]
Bug 1419440 - Update for API change in WR PR 2082.
https://reviewboard.mozilla.org/r/202510/#review207876
Attachment #8931372 -
Flags: review?(mstange) → review+
Comment 17•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4bd54453fd2e
Update webrender to commit b7b07562fda338fcb2faff66ce01aafb6235fbcf. r=mstange
https://hg.mozilla.org/integration/autoland/rev/85a4275ed544
Update for API changes in WR PR 2050. r=kats
https://hg.mozilla.org/integration/autoland/rev/b7bc562d77f1
Update for API change in WR PR 2082. r=mstange
Comment 18•7 years ago
|
||
This update seems to introduce crashes due to https://github.com/servo/webrender/issues/2093 .
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4bd54453fd2e
https://hg.mozilla.org/mozilla-central/rev/85a4275ed544
https://hg.mozilla.org/mozilla-central/rev/b7bc562d77f1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•3 years ago
|
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•