Closed Bug 1392343 Opened 7 years ago Closed 7 years ago

Convert button display items to webrender

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected

People

(Reporter: jrmuizel, Assigned: kechen)

References

Details

(Keywords: stale-bug, Whiteboard: [wr-reserve] [gfx-noted])

Attachments

(2 files)

We should be able to handle non-theme items without any trouble. These show up on facebook.
Depends on: 1392470
Whiteboard: [gfx-noted]
Assignee: nobody → kechen
Depends on: 1393383
There are three reasons that prevent facebook enter page from converting button display items to webrender : 1. We fallback and create original display items when there is no BorderRenderer[1]; but no BorderRenderer actually means we don't need to draw borders(might because border width/height is 0) so we shouldn't fallback here. 2. nsDisplayBoxShadowInner don't create webrender display items when there is border radius; however, we can deal with border radius with the same radii so I loose the fallback condition. 3. Currently we don't use webrender for styled borders, we should unlock them. These patches might cause some reftest fails[2], these patches can not fix all of them currently. [1] https://dxr.mozilla.org/mozilla-central/rev/db7f19e26e571ae1dd309f5d2f387b06ba670c30/layout/forms/nsButtonFrameRenderer.cpp#339 [2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=5409b0721876d39e4bbb441f7ae495724016f02b
Per discuss with Ethan; we decided to separate the issues in comment three into different bugs since some of them need further discussion.
Depends on: 1396491
Depends on: 1396492
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Target Milestone: --- → mozilla57
Any update on this work?
Flags: needinfo?(kechen)
The only non-theme item we haven't handled in facebook page is styled borders. I will enable it in Bug 1396491.
No longer depends on: 1393383
Flags: needinfo?(kechen)
Depends on: 1409243
Whiteboard: [wr-mvp] [gfx-noted] → [wr-reserve] [gfx-noted]
This problem is fixed after bug 1409243 is landed.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: