Closed
Bug 1396492
Opened 7 years ago
Closed 7 years ago
Support uniform radius for nsDisplayBoxShadowInner
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox56 | --- | unaffected |
firefox57 | --- | unaffected |
People
(Reporter: kechen, Assigned: kechen)
References
Details
(Whiteboard: [wr-mvp])
Attachments
(1 file)
We should able to support box shadows with a uniform border radius in WR.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
This patch allows nsDisplayBoxShadowInner to render uniform radius via WebRender.
Some reftests are needed to be fuzzed due to the following reasons:
1. boxshadow-border-radius-int.html :
There are a little differences between inner shadow between the cases that with and without border radius which is rendered by WebRender.
2. fieldset-inset.html :
nsDisplayFieldSetBorder for WebRender is not supported in gecko; therefore, before the implementation is completed, this test will be a comparison between old compositor and WebRender.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8904397 [details]
Bug 1396492 - Support uniform radius for nsDisplayBoxShadowInner;
https://reviewboard.mozilla.org/r/176204/#review181872
Attachment #8904397 -
Flags: review?(jmuizelaar) → review+
Updated•7 years ago
|
Blocks: stage-wr-nightly
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [wr-mvp]
Target Milestone: --- → mozilla57
Comment hidden (mozreview-request) |
Updated•7 years ago
|
status-firefox56:
--- → unaffected
status-firefox57:
--- → unaffected
Assignee | ||
Comment 6•7 years ago
|
||
I will land this patch after 9/21 since the soft freeze.
Comment 7•7 years ago
|
||
Since this only touches CanCreateWebRenderCommands the likeliness of it causes regression should be really low. You shouldn't have to wait for 9/21.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•7 years ago
|
||
Here is the try result[1], this patch should only affect QuantumRender build; the failures in other builds are not related to this patch.
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdfba1e072fe7ed9f9ddf9bb314393306eb350d4
Keywords: checkin-needed
Comment 11•7 years ago
|
||
bugherder landing |
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•