Closed
Bug 1392884
Opened 7 years ago
Closed 7 years ago
Remove nsIAtomService
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
nsIAtomService is barely used in Firefox, and used a small amount in Thunderbird. Getting rid of it will allow us to deCOMtaminate nsIAtom (bug 1392883).
|
Assignee | |
Comment 1•7 years ago
|
||
Holy smokes, if a script passes a string to an interface that expects an nsIAtom, XPConnect will atomize the string!
http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/js/xpconnect/src/XPCConvert.cpp#694-706
(That explains why editor/libeditor/tests/test_bug1140105.html was succeeding even after I changed its atoms to strings.)
Once nsIAtom is made non-scriptable, that conversion code can be removed.
|
|
Assignee | |
Comment 2•7 years ago
|
||
The blocking bugs needs to be completed first, but this patch is ready for
review.
Attachment #8901061 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8901061 [details] [diff] [review]
Remove nsIAtomService
Review of attachment 8901061 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for taking so long with this, this patch is great and trivial to review!
Attachment #8901061 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2cc3ce26632a1551b822dce0b81dfae459c0b84
Bug 1392884 - Remove nsIAtomService. r=froydnj.
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•