Closed Bug 1392989 Opened 7 years ago Closed 7 years ago

Remove some unused nsIAtom/nsIAtomService references from JS code

Categories

(Toolkit :: General, enhancement)

Product:
Toolkit
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(2 files)

(part 1) - Remove convertProperties()
(deleted), patch
jaws
: review+
Details | Diff | Splinter Review
(part 2) - Remove unused atom-service references
(deleted), patch
jaws
: review+
Details | Diff | Splinter Review
Bug 1392884 is about removing nsIAtomService. There are some easy things we can remove in JS code.
It's unused.
Attachment #8900199 - Flags: review?(jaws)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Plus a couple of other unused service references nearby.
Attachment #8900201 - Flags: review?(jaws)
Comment on attachment 8900199 [details] [diff] [review] (part 1) - Remove convertProperties() Review of attachment 8900199 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! One day our linting tools should get good enough that they will call out this dead code.
Attachment #8900199 - Flags: review?(jaws) → review+
Attachment #8900201 - Flags: review?(jaws) → review+
Blocks: 1392884, 1392883
https://hg.mozilla.org/mozilla-central/rev/a35d3053142f https://hg.mozilla.org/mozilla-central/rev/bd91f57410f2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: