Require libclang 4.0+ for stylo.
Categories
(Firefox Build System :: General, defect, P3)
Tracking
(firefox-esr52 unaffected, firefox55 unaffected, firefox56 wontfix, firefox57 wontfix, firefox58 wontfix, firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | wontfix |
firefox57 | --- | wontfix |
firefox58 | --- | wontfix |
firefox67 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Whiteboard: [stylo])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Assignee | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Updated•7 years ago
|
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Updated•7 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Mike, we still build the base toolchains job with clang 3.9 only for bindgen (since we use GCC for the C++ code IIUC). I don't see anything else using linux64-clang-3.9
, is that right?
If so, can we update it to, let's say, clang 5.0? (4.0 would be ok too I guess). I'm happy to figure out the way to tweak the json file in build/build-clang/clang-3.9-linux64.json
if you cannot / don't want to do it.
Comment 9•6 years ago
|
||
I actually want to setup builds with the minimum clang we claim to support which is 3.9 at the moment (independently of bindgen). It may or may not be worthwhile to update the minimum clang version we claim to support, but we should at least check out which one(s) work.
Assignee | ||
Comment 10•6 years ago
|
||
Huh, as it turns out, this is blocking some changes I want to do to the style system. We have already so many hacks to workaround libclang 3.9 bugs that are fixed in 4.0 that I took a stab at this.
With 3.9:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1122db9ff531e4c626d9048e27d88e8cc8bc511
With 4.0:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f530666dc2308502b9d3257ce1220d1ff34751e4 (not done yet, but has finished linking libxul, so it did build).
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 11•6 years ago
|
||
Note that we only use this for libclang at the moment, since
base-toolchains is built with gcc.
libclang 3.9 has a bug that makes bindgen unable to distinguish some typedefs
from the underlying type, which matters for bug 1523071.
We have had quite a few workarounds for this bug and I don't really want to add
more, since in this case it is non-trivial. I think requiring libclang 4.0+ is
reasonable at this point.
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
bugherder |
Assignee | ||
Updated•6 years ago
|
Description
•